Cleaning up packaging for package
#4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4424 +/- ##
==========================================
Coverage 93.38% 93.38%
==========================================
Files 171 185 +14
Lines 21744 22858 +1114
Branches 4014 4014
==========================================
+ Hits 20305 21346 +1041
- Misses 952 1025 +73
Partials 487 487 ☔ View full report in Codecov by Sentry. |
IAlibay
changed the title
packagepackage
RMeli
approved these changes
Feb 22, 2024
package/pyproject.toml
Outdated
Comment on lines
99
to
100
| "Project URL" = "https://www.mdanalysis.org" | ||
| "Download URL" = "https://github.com/MDAnalysis/mdanalysis/releases" |
There was a problem hiding this comment.
Suggested change
| "Project URL" = "https://www.mdanalysis.org" | |
| "Download URL" = "https://github.com/MDAnalysis/mdanalysis/releases" | |
| Homepage = "https://www.mdanalysis.org" | |
| Downloads = "https://github.com/MDAnalysis/mdanalysis/releases" |
? Just a suggestion, but "URL" feels a repetition since the field is already [project.urls].
There was a problem hiding this comment.
Looks good, I went with this but with a non-plural Download instead.
RMeli
reviewed
Feb 22, 2024
3 tasks
RMeli
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect a lot to break whilst it's being worked on but should show what the redudant bits are at least.
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4424.org.readthedocs.build/en/4424/