-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Zarr Trajectory format #4557
Conversation
Linter Bot Results:Hi @ljwoods2! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4557 +/- ##
===========================================
- Coverage 93.66% 93.64% -0.03%
===========================================
Files 168 180 +12
Lines 21248 22333 +1085
Branches 3917 3917
===========================================
+ Hits 19902 20913 +1011
- Misses 888 962 +74
Partials 458 458 ☔ View full report in Codecov by Sentry. |
@ljwoods2 as I think you know, this will have to be held, until the zarrtraj stuff is more mature. Is there a general case though that this PR solves? E.G chainreader cannot handle objects that are not XX or YY? |
Maybe it's as simple as iterating through all _format_hint() methods except for chainreader before checking chainreader |
@ljwoods2 instead of "WIP" in the title you can also "convert to draft" to make the state extra clear (and really properly tagged in GH instead using a convention). It also has the advantage that you then only need a click (instead of a title change) when you're ready. |
Closing this because zarrtraj accepts filename strings instead of zarr.Group objects now, so no change to format_hint is needed |
Changes made in this Pull Request:
This is just one way I am proposing to allow future compatibility with the zarrtraj format (https://github.com/Becksteinlab/zarrtraj) that I'm developing in Oliver's lab (and potentially GSOC). Since the zarrtraj format is still in the prototyping phase, there is no urgency to merge this or an alternate solution and I'm open to different ways of approaching it.
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4557.org.readthedocs.build/en/4557/