Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to version of rdkit that works with mypy #4580

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Pin to version of rdkit that works with mypy #4580

merged 1 commit into from
Apr 28, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Apr 28, 2024

Changes made in this Pull Request:

  • Pin mypy linting action to 2023.09.3

Not 100% sure why this is happening, we're tracking this elsewhere: OpenFreeEnergy/openfe#844

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4580.org.readthedocs.build/en/4580/

Copy link

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (804b607) to head (44291d5).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4580      +/-   ##
===========================================
- Coverage    93.64%   93.62%   -0.02%     
===========================================
  Files          168      180      +12     
  Lines        21254    22333    +1079     
  Branches      3918     3918              
===========================================
+ Hits         19904    20910    +1006     
- Misses         892      965      +73     
  Partials       458      458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for already opening the issue reminding us to eventually unpin this.

@RMeli RMeli merged commit 03fceba into develop Apr 28, 2024
24 of 25 checks passed
@IAlibay IAlibay deleted the fix-mypy branch April 28, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants