Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] fix RDF equation (and hole link) #4591

Merged
merged 2 commits into from
May 8, 2024
Merged

[doc] fix RDF equation (and hole link) #4591

merged 2 commits into from
May 8, 2024

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented May 7, 2024

Corrects error in the RDF equation as noted by @rodpollet #4437 (reply in thread)

Changes made in this Pull Request:

  • fix RDF g_ab equation
  • fix missing reST link in the (deprecated) hole2 module

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4591.org.readthedocs.build/en/4591/

@orbeckst orbeckst requested review from hmacdope and lilyminium May 7, 2024 22:45
@pep8speaks
Copy link

Hello @orbeckst! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 35:80: E501 line too long (82 > 79 characters)

Copy link

github-actions bot commented May 7, 2024

Linter Bot Results:

Hi @orbeckst! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @orbeckst

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (45fb664) to head (61d05a9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4591      +/-   ##
===========================================
- Coverage    93.64%   93.62%   -0.02%     
===========================================
  Files          168      180      +12     
  Lines        21254    22333    +1079     
  Branches      3918     3918              
===========================================
+ Hits         19904    20910    +1006     
- Misses         892      965      +73     
  Partials       458      458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmacdope hmacdope merged commit 0f04e3e into develop May 8, 2024
22 of 25 checks passed
@RMeli RMeli deleted the fix-rdf-equation branch July 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants