-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'MDAnalysis.analysis.nucleicacids' parallelization #4727
base: develop
Are you sure you want to change the base?
Conversation
added backend and aggregators
added NucPairDist to the conftest.py
added client_NucPairDist to the tests
Linter Bot Results:Hi @talagayev! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-23 00:47:12 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4727 +/- ##
===========================================
+ Coverage 93.55% 93.62% +0.07%
===========================================
Files 173 187 +14
Lines 21463 22634 +1171
Branches 3987 3023 -964
===========================================
+ Hits 20080 21192 +1112
- Misses 929 998 +69
+ Partials 454 444 -10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Could you also help fix the pep8?
Yes, I have now access again to a PC, although with slow internet, so I will adjust it for pep8 and also add the additional stuff that is missing (changelog etc.). I would also create an additional PR draft for |
fixing PEP
added versionchanged for addition of parallelization
Added Parallelization of nucleicacids.py and fixed lettering
Addition of mention of modification to self.results.distances
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
removed _res_dict
moved back _res_dict
removed _res_sel
remove unecessary ,
@yuxuanzhuang thanks for the review. Could you please shepherd the PR to completion? (I think we're in feature-freeze for 2.8.0 #4733 but check the issue for updates.) |
Fixes #4670 attempt
Changes made in this Pull Request:
NucPairDist
inanalysis.nucleicacids
client_NucPairDist
inconftest.py
client_NucPairDist
inrun()
intest_nucleicacids.py
Here the Error:
AttributeError: 'WatsonCrickDist' object has no attribute '_res_array'
appears for all of the tests where theclient_NucPairDist
is used, same goes not only forWatsonCrickDist
, but also forMinorPairDist
andMajorPairDist
.I am a little bit stuck, since I am not sure if I need to modify the
analysis.nucleicacids
to fix this error, thus I made this PR as a draft to get more input and ideas how to fix this issue :)PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4727.org.readthedocs.build/en/4727/