Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4339 #4830

Closed
wants to merge 2 commits into from
Closed

Issue 4339 #4830

wants to merge 2 commits into from

Conversation

tanishy7777
Copy link
Contributor

@tanishy7777 tanishy7777 commented Dec 12, 2024

Fixes #4339

Changes made in this Pull Request:

  • Changed the function atan2() to np.atan2() to avoid converting array to scalar

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4830.org.readthedocs.build/en/4830/

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (a27591c) to head (bf46040).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4830      +/-   ##
===========================================
- Coverage    93.68%   93.66%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21743    22809    +1066     
  Branches      3055     3055              
===========================================
+ Hits         20370    21363     +993     
- Misses         927     1000      +73     
  Partials       446      446              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array to scalar deprecation warning
1 participant