-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes deprecation warning and updated CHANGELOG #4831
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4831 +/- ##
===========================================
- Coverage 93.68% 93.66% -0.03%
===========================================
Files 177 189 +12
Lines 21743 22809 +1066
Branches 3055 3055
===========================================
+ Hits 20370 21363 +993
- Misses 927 1000 +73
Partials 446 446 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. In addition to the comments inline, could you please also demonstrate that your changes fix the issue? Can you please show that before your changes, the warning is issued and that afterwards it is gone, e.g., by running pytest MDAnalysisTests/analysis/test_nuclinfo.py
and showing all the output?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fix!
Fixes #4339
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4831.org.readthedocs.build/en/4831/