Fixes MDAnalysis.analysis.density.convert_density() method has an invalid default unit value#4833
Merged
RMeli merged 5 commits intoMDAnalysis:developfrom Dec 14, 2024
Merged
Conversation
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4833 +/- ##
===========================================
- Coverage 93.65% 93.63% -0.03%
===========================================
Files 177 189 +12
Lines 21763 22829 +1066
Branches 3065 3065
===========================================
+ Hits 20382 21375 +993
- Misses 929 1002 +73
Partials 452 452 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Conflicts needs to be resolved here too, otherwise it's good to go. |
RMeli
requested changes
Dec 14, 2024
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
RMeli
approved these changes
Dec 14, 2024
amruthesht
pushed a commit
to amruthesht/mdanalysis
that referenced
this pull request
Feb 19, 2025
…alid default unit value (MDAnalysis#4833)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes #4829
Changes made in this Pull Request:
Angstrom^{-3}fromAngstromtestsuite/MDAnalysisTests/analysis/test_density.pyBefore
After
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4833.org.readthedocs.build/en/4833/