Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] switched from macOS-12 to macOS-13 GH images #4836

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Dec 13, 2024

fix #4835

Changes made in this Pull Request:

  • use macos-13 instead of macos-12 images in all CI workflows

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4836.org.readthedocs.build/en/4836/

@orbeckst orbeckst requested a review from IAlibay December 13, 2024 16:52
@orbeckst
Copy link
Member Author

I am not sure what the difference between MacOS-12 and MacOS-13 is but I am going on the assumption that we want to check the lowest available.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (f4e0f0b) to head (455773d).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4836      +/-   ##
===========================================
- Coverage    93.68%   93.66%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21743    22809    +1066     
  Branches      3055     3055              
===========================================
+ Hits         20370    21363     +993     
- Misses         927     1000      +73     
  Partials       446      446              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, yeah this is the right thing to do.

@IAlibay IAlibay merged commit fa73478 into develop Dec 13, 2024
25 of 26 checks passed
@IAlibay IAlibay deleted the ci-macos-13 branch December 13, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] GH runner macOS-12 fails with *internal error*: image removed
2 participants