Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add
relprop
for atom selection and corresponding UT #4841base: develop
Are you sure you want to change the base?
add
relprop
for atom selection and corresponding UT #4841Changes from 2 commits
350c5a5
08f8b98
2ac868b
a5b7bf9
cda4dca
2b4ab7a
f960ea7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1380 in package/MDAnalysis/core/selection.py
Codecov / codecov/patch
package/MDAnalysis/core/selection.py#L1377-L1380
Check warning on line 1385 in package/MDAnalysis/core/selection.py
Codecov / codecov/patch
package/MDAnalysis/core/selection.py#L1384-L1385
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your docs should make clear that the COM of the second group is used.
Is this what this selection should do? Or should it calculate all-vs-all distances and then compute the min over all distances and then compare this minimal distance to the value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using center_of_geometry you also need to think carefully to what value
wrap
andunwrap
needs to be set, especially if the user does not get a choice in setting it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. COG (not COM) is what I want to implement. In my cases, the planar surfaces are used, and taking the average positions of the surfaces is better than the minimal distances as reference. But I can see the case when the minimal distance would be a better choice, for example, for the curved surfaces. I suggest to have a new selecton class. What is your opinion?