Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] Format converters modules and tests #4850

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Dec 20, 2024

[fmt] Format converters modules and tests. Some files actives in current PRs are ignored and will be formatted once the corresponding PRs are merged (see #4815).


📚 Documentation preview 📚: https://mdanalysis--4850.org.readthedocs.build/en/4850/

@pep8speaks
Copy link

pep8speaks commented Dec 20, 2024

Hello @RMeli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 274:35: E203 whitespace before ':'
Line 274:48: E203 whitespace before ':'
Line 279:46: E203 whitespace before ':'
Line 279:59: E203 whitespace before ':'

Line 140:46: E203 whitespace before ':'

Line 487:80: E501 line too long (80 > 79 characters)
Line 685:80: E501 line too long (85 > 79 characters)
Line 686:80: E501 line too long (84 > 79 characters)
Line 687:80: E501 line too long (80 > 79 characters)
Line 688:80: E501 line too long (88 > 79 characters)
Line 690:80: E501 line too long (121 > 79 characters)
Line 692:80: E501 line too long (97 > 79 characters)
Line 693:80: E501 line too long (95 > 79 characters)
Line 696:80: E501 line too long (85 > 79 characters)

Comment last updated at 2024-12-20 22:28:31 UTC

@RMeli RMeli requested review from IAlibay and marinegor December 20, 2024 21:08
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.65%. Comparing base (4f143fd) to head (19a6980).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
package/MDAnalysis/converters/OpenMMParser.py 71.42% 1 Missing and 1 partial ⚠️
package/MDAnalysis/converters/ParmEd.py 94.87% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4850   +/-   ##
========================================
  Coverage    93.65%   93.65%           
========================================
  Files          177      177           
  Lines        21779    21779           
  Branches      3064     3064           
========================================
  Hits         20398    20398           
  Misses         929      929           
  Partials       452      452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marinegor marinegor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RMeli RMeli removed the request for review from IAlibay December 20, 2024 22:26
@RMeli RMeli enabled auto-merge (squash) December 21, 2024 08:22
@RMeli RMeli disabled auto-merge December 21, 2024 08:22
@RMeli RMeli enabled auto-merge (squash) December 21, 2024 08:22
@RMeli RMeli merged commit 9110a6e into MDAnalysis:develop Dec 21, 2024
17 checks passed
@RMeli RMeli deleted the fmt-converters branch December 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants