Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] Format everything but package and testsuite #4859

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Dec 22, 2024

Formatting of everything excluded from package and testsuite. I did not add a .black configuration file for these files that are not touched often, but will probably do at the very end of the whole process.


📚 Documentation preview 📚: https://mdanalysis--4859.org.readthedocs.build/en/4859/

@pep8speaks
Copy link

Hello @RMeli! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 367:80: E501 line too long (80 > 79 characters)

Line 27:80: E501 line too long (82 > 79 characters)
Line 29:80: E501 line too long (82 > 79 characters)
Line 31:80: E501 line too long (82 > 79 characters)
Line 33:80: E501 line too long (82 > 79 characters)
Line 35:80: E501 line too long (84 > 79 characters)
Line 37:80: E501 line too long (81 > 79 characters)
Line 40:42: E203 whitespace before ':'
Line 130:80: E501 line too long (80 > 79 characters)
Line 142:80: E501 line too long (82 > 79 characters)

Line 35:80: E501 line too long (83 > 79 characters)

Line 17:80: E501 line too long (81 > 79 characters)

Line 67:80: E501 line too long (81 > 79 characters)

Line 28:80: E501 line too long (86 > 79 characters)

Line 24:80: E501 line too long (84 > 79 characters)
Line 33:80: E501 line too long (88 > 79 characters)

@RMeli RMeli requested a review from marinegor December 22, 2024 22:04
@RMeli
Copy link
Member Author

RMeli commented Dec 22, 2024

This is good to go IMO.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (9110a6e) to head (c0274e3).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4859      +/-   ##
===========================================
- Coverage    93.65%   93.63%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21779    22845    +1066     
  Branches      3064     3064              
===========================================
+ Hits         20398    21391     +993     
- Misses         929     1002      +73     
  Partials       452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blanket LGTM — please merge when you're happy with it @RMeli

🎄 🎁

@RMeli RMeli merged commit 9312fa6 into MDAnalysis:develop Dec 24, 2024
25 of 26 checks passed
@RMeli RMeli deleted the fmt-misc branch December 24, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants