Fix documentation for geometric selections with PBC (#2166)#5305
Open
AkshitBoora wants to merge 1 commit intoMDAnalysis:developfrom
Open
Fix documentation for geometric selections with PBC (#2166)#5305AkshitBoora wants to merge 1 commit intoMDAnalysis:developfrom
AkshitBoora wants to merge 1 commit intoMDAnalysis:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5305 +/- ##
========================================
Coverage 93.82% 93.82%
========================================
Files 182 182
Lines 22487 22487
Branches 3196 3196
========================================
Hits 21099 21099
Misses 925 925
Partials 463 463 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi @AkshitBoora. We admire your enthusiasm towards improving MDAnalysis, but we won't be reviewing your PRs unless you restore the PR template and answer those sections in detail. This is the same with #5311. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2166
Updates the documentation for geometric selections to correctly describe
how periodic boundary conditions (PBC) are handled.
Changes:
This improves the accuracy of the documentation and aligns it with the
current implementation in MDAnalysis.
📚 Documentation preview 📚: https://mdanalysis--5305.org.readthedocs.build/en/5305/