-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update conda env files #132
Conversation
- only use conda-forge channel (removed defaults) - install MDAnalysis via conda instead of pip
Why the f*** is the Ubuntu 3.10 job https://github.com/MDAnalysis/membrane-curvature/actions/runs/9986845992/job/27600076214?pr=132 installing MDA 2.1.0
even though the spec is "MDAnalysis[>=2.0.0]": shouldn't it just go and find 2.7.0? It then dies with
which is not surprising, given that we also installed numpy 2.0.0
and apparently our MDA 2.1 cf package did not restrict the numpy versions on the upper end. |
Makes sense, the resolution order will be to pick up the highest version of numpy and the lowest version of MDAnalysis. |
I pushed some changes, i.e. removed This does however point to the fact that if someone wants to install MDA right now, they'll probably encounter issues if they are doing a pure install with numpy (or anything upstream that has removed its MDA pins). |
dependencies: | ||
- python | ||
- pip | ||
- numpy==1.20.0 | ||
- numpy==1.21.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest just removing 3.9 and bumping this up - but if folks are intent on keeping 3.9, then at least increasing to 1.21.0 is a need (since osx-arm64 will require 1.21+ for py39).
The main reason we're bumping here is because newer scipy will work with older numpy, but features are mostly turned off (like pkdtree).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 3.9 is included here because it’s the minimally supported version and that’s what this test is supposed to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry what I meant here was "maybe the minimum should be Python 3.10 not 3.9"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to bump the minimally supported Python version of membrane-curvature to 3.10 then we can do that (even though its dependencies still support 3.9). If we bump then we should do a new release with advertised 3.10 - 3.12 (not sure if 3.12 is in pyproject.toml).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in there — so it would just be removing 3.9 along spec0 Blabla.
Thanks @IAlibay — now all tests pass again 🎉 I’d leave the ‘min’ test for now unless people think it’s useless. We do need an approving review to merge. |
I am going to merge for right now and we can change the minimum supported version in another PR. |
Description
The conda env files that are being used for CI appeared outdated. In this PR I am trying out if they can be simplified.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status