-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update conda env files #132
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
40a2e43
update conda env files
orbeckst 6ffcc55
Update environment.yaml
IAlibay 9e6d477
Update test_env.yaml
IAlibay bf1011f
Update test_min.yaml
IAlibay fcb8b55
Update test_min.yaml
IAlibay d579f44
Update pyproject.toml
IAlibay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,7 @@ | ||
| name: membrane-curvature | ||
| channels: | ||
| - conda-forge | ||
| - defaults | ||
| dependencies: | ||
| - python | ||
| - pip | ||
| - numpy | ||
|
|
||
| # Pip-only installs | ||
| - pip: | ||
| - MDAnalysis>=2.0.0b0 | ||
| - MDAnalysis>=2.0.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,12 @@ | ||
| name: test | ||
| channels: | ||
| - conda-forge | ||
| - defaults | ||
| dependencies: | ||
| - python | ||
| - pip | ||
| - numpy | ||
| - sphinx | ||
| - MDAnalysis>=2.0.0 | ||
| # Testing | ||
| - pytest | ||
| - pytest-cov | ||
| - codecov | ||
|
|
||
| # Pip-only installs | ||
| - pip: | ||
| - MDAnalysis>=2.0.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,13 @@ | ||
| name: test | ||
| channels: | ||
| - conda-forge | ||
| - defaults | ||
| dependencies: | ||
| - python | ||
| - pip | ||
| - numpy==1.20.0 | ||
| - numpy==1.21.0 | ||
| - MDAnalysis==2.0.0 | ||
| - sphinx | ||
| # Testing | ||
| - pytest | ||
| - pytest-cov | ||
| - codecov | ||
|
|
||
| # Pip-only installs | ||
| - pip: | ||
| - MDAnalysis==2.0.0 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest just removing 3.9 and bumping this up - but if folks are intent on keeping 3.9, then at least increasing to 1.21.0 is a need (since osx-arm64 will require 1.21+ for py39).
The main reason we're bumping here is because newer scipy will work with older numpy, but features are mostly turned off (like pkdtree).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 3.9 is included here because it’s the minimally supported version and that’s what this test is supposed to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry what I meant here was "maybe the minimum should be Python 3.10 not 3.9"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to bump the minimally supported Python version of membrane-curvature to 3.10 then we can do that (even though its dependencies still support 3.9). If we bump then we should do a new release with advertised 3.10 - 3.12 (not sure if 3.12 is in pyproject.toml).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in there — so it would just be removing 3.9 along spec0 Blabla.