-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidal deformation #773
base: main
Are you sure you want to change the base?
Tidal deformation #773
Conversation
# Conflicts: # star/private/hydro_rotation.f90
Not a blocker for me but would it be possible to use this in the test suite somewhere, be that in a new test or tweaking an existing one? |
Certainly this needs a test_suite. I would love to test it out as well. |
As a first test, |
Following on #637, this (rather large) overhaul of
hydro_rotation.f90
includes support for computing the stellar structure corrections of tidally distorted stars. This is especially useful when modeling contact binaries.The setup is as follows:
I used procedure hooks (akin to
binary_other_torque
for tidal J_dot calculations) to communicate the binary calculated fp, ft, and i_rot values for the stellar layers.Then these values are "blended" with the single-rotating-star corrections according to the synchronicity of the component to the orbit. I implemented a user hook
binary_other_tidal_deformation_switch_function
if one does not agree with this treatment.The user can still use the
other_fp_ft
andother_i_rot
hooks to bypass all default calculations (and blending).