Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidal deformation #773

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Tidal deformation #773

wants to merge 26 commits into from

Conversation

matthiasfabry
Copy link
Contributor

Following on #637, this (rather large) overhaul of hydro_rotation.f90 includes support for computing the stellar structure corrections of tidally distorted stars. This is especially useful when modeling contact binaries.

The setup is as follows:

I used procedure hooks (akin to binary_other_torque for tidal J_dot calculations) to communicate the binary calculated fp, ft, and i_rot values for the stellar layers.
Then these values are "blended" with the single-rotating-star corrections according to the synchronicity of the component to the orbit. I implemented a user hook binary_other_tidal_deformation_switch_function if one does not agree with this treatment.

The user can still use the other_fp_ft and other_i_rot hooks to bypass all default calculations (and blending).

@matthiasfabry matthiasfabry added enhancement New feature or request binary Binary module rotation Capabilities for modeling rotating stars labels Jan 31, 2025
binary/make/makefile Outdated Show resolved Hide resolved
@warrickball
Copy link
Contributor

Not a blocker for me but would it be possible to use this in the test suite somewhere, be that in a new test or tweaking an existing one?

@Debraheem
Copy link
Member

Certainly this needs a test_suite. I would love to test it out as well.

@matthiasfabry
Copy link
Contributor Author

As a first test, double_bh contains a contact phase, plus it has strong tides, so this is a natural environment for the tidal deformation corrections. I incorporated a pgbinary window for good measure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary Binary module enhancement New feature or request rotation Capabilities for modeling rotating stars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants