-
Notifications
You must be signed in to change notification settings - Fork 48
Tidal deformation #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthiasfabry
wants to merge
32
commits into
main
Choose a base branch
from
tidal_deformation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tidal deformation #773
Changes from 21 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
d252780
[ci skip] add roche geometry data
c44f598
[ci skip] introduce procedure interfaces akin to binary_torque
fe0f398
[ci skip] associate procedure hooks
43ee89d
[ci skip] add main routines where computations happen
3f39198
[ci skip] add calls to build interpolators
ed9bfd7
[ci skip] add to build list
f2a8075
[ci skip] add explicit interfaces in star_data_def.inc
acfc9bc
select which deformation routines to use, flip fp/ft in signatures
e88f444
change i_rot signatures
8140dac
fix circular dependence
3575e54
do namelist ctrl_io
38ea77a
Merge branch 'adjust_J_q-bug' into tidal_deformation
09aea37
introduce single-to-tidal switching controls
6ab47dc
introduce single-to-tidal switching in hydro_rotation.f90
a9b4768
introduce single-to-tidal switching defaults
615b1d2
implement default single-to-tidal switching function
4718df1
implement hook for user-defined single-to-tidal switching function
e037a66
do irot in terms of 2/3 r_psi^2
69a1ee8
Merge branch 'main' into tidal_deformation
107d4df
fix-up merge
728b6f2
changelog entry
a8fb340
quiet + inter_ok outside dbg
94863f9
apply warrick's review
a716af8
always put fp first + fix ppisn other_eval_fp_ft signature
2f0e80b
Merge branch 'main' into tidal_deformation
5d3101d
let double_bh use tidal deformation
d31f3bc
Merge remote-tracking branch 'refs/remotes/origin/main' into tidal_de…
c4eb749
fix fortitude warnings
c79cdd6
[ci optional] fix errors in ppisn and magnetic braking; full test
3bab30c
[ci skip] const def module wide
11e07f0
[ci skip] fix floats in run_star_extras.f90 of ppisn
02c9f7d
Merge remote-tracking branch 'origin/main' into tidal_deformation
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
binary/other/mod_other_tidal_deformation_switch_function.f90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
! *********************************************************************** | ||
! | ||
! Copyright (C) 2025 Matthias Fabry and the MESA Team | ||
! | ||
! MESA is free software; you can use it and/or modify | ||
! it under the combined terms and restrictions of the MESA MANIFESTO | ||
! and the GNU General Library Public License as published | ||
! by the Free Software Foundation; either version 2 of the License, | ||
! or (at your option) any later version. | ||
! | ||
! You should have received a copy of the MESA MANIFESTO along with | ||
! this software; if not, it is available at the mesa website: | ||
! http://mesa.sourceforge.net/ | ||
! | ||
! MESA is distributed in the hope that it will be useful, | ||
! but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
! MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. | ||
! See the GNU Library General Public License for more details. | ||
! | ||
! You should have received a copy of the GNU Library General Public License | ||
! along with this software; if not, write to the Free Software | ||
! Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | ||
! | ||
! *********************************************************************** | ||
|
||
module mod_other_tidal_deformation_switch_function | ||
|
||
! NOTE: remember to set true: | ||
! use_other_tidal_deformation_function = .true. | ||
|
||
! you can add your own routine for use instead of the default one. | ||
! the default routine uses the synchronicity parameter to switch from single rotating to tidal corrections. | ||
! When the shell is quite synchronous, f_switch -> 1, when not synchronous, f_switch -> 0. It uses a sigmoid around | ||
! omega/omega_sync = b% f_sync_switch_from_rot_defor to smoothly vary f_switch from 0 to 1. | ||
|
||
use const_def | ||
|
||
implicit none | ||
|
||
contains | ||
|
||
subroutine null_other_tidal_deformation_switch_function(id, k, omega_in, f_switch, ierr) | ||
integer, intent(in) :: id, k | ||
real(dp), intent(in) :: omega_in | ||
real(dp), intent(out) :: f_switch | ||
integer, intent(out) :: ierr | ||
include 'formats' | ||
|
||
write (*, 1) 'no implementation for other_tidal_deformation_function' | ||
! must set f_switch | ||
ierr = -1 | ||
matthiasfabry marked this conversation as resolved.
Show resolved
Hide resolved
|
||
end subroutine null_other_tidal_deformation_switch_function | ||
|
||
|
||
end module mod_other_tidal_deformation_switch_function | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.