Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMakeLists.txt to fix #237 Add fatal error to cmakelists if debug + gpu is enabled with NVHPC <= 22.11 #238

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Update CMakeLists.txt to fix #237 Add fatal error to cmakelists if debug + gpu is enabled with NVHPC <= 22.11 #238

merged 6 commits into from
Dec 11, 2023

Conversation

sbryngelson
Copy link
Member

Add fatal error to cmakelists if debug + gpu is enabled with NVHPC <= 23.0

@sbryngelson
Copy link
Member Author

I found that I cannot build --debug with NVHPC + CPU on new nor old NVHPC versions. I have updated the CMakeLists to reflect the current state.

@sbryngelson
Copy link
Member Author

For review + squash-merge by @henryleberre

@sbryngelson sbryngelson linked an issue Nov 23, 2023 that may be closed by this pull request
Add fatal error to cmakelists if debug + gpu is enabled with NVHPC <= 22.11 #237
Closed
@sbryngelson sbryngelson mentioned this pull request Nov 23, 2023
Closed
@sbryngelson
Copy link
Member Author

sbryngelson commented Nov 23, 2023 •
edited
Loading

Update: I found that even after removing all of the CMakeLists.txt compiler flag additions, the debug CPU build with NVHPC v23.5 does not work (available on Wingtip3 and TAMU ACES [on ACCESS-CI/XSEDE]). The CMakeCache shows that debug NVHPC builds automatically add flags -g -O0 -Mbounds.

I assume it's -Mbounds that's causing the problem, which don't really know. The error message is just an obscure exit code.

@sbryngelson sbryngelson mentioned this pull request Nov 23, 2023
Closed
henryleberre
henryleberre reviewed Nov 26, 2023
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
@henryleberre henryleberre self-requested a review December 11, 2023 06:21
@sbryngelson sbryngelson merged commit d77ba09 into master Dec 11, 2023
0 of 30 checks passed
@sbryngelson sbryngelson deleted the sbryngelson-patch-1 branch December 11, 2023 13:25
JRChreim pushed a commit to JRChreim/MFC-JRChreim that referenced this pull request Dec 21, 2023
@sbryngelson @JRChreim
Update CMakeLists.txt to fix MFlowCode#237 Add fatal error to cmakeli…
f63c591 
…sts if debug + gpu is enabled with NVHPC <= 22.11 (MFlowCode#238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryleberre henryleberre henryleberre approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fatal error to cmakelists if debug + gpu is enabled with NVHPC <= 22.11
2 participants
@sbryngelson @henryleberre