Add an improved graphqlOperationLoggingPlugin
, deprecate the old loggingPlugin
#141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ?
Add new improved GraphQL operation logging plugin.
Why ?
Over in another project we added audit logging output via
logger.audit(...)
We wanted to audit every GraphQL operation with features not offered by the current
loggingPlugin
, so we added the following features:loggingPlugin
shouldIgnore
callback had a strange signature not matching the data received by apollo plugins (breaking change)Why not modify the existing logging plugin?
Since there are two breaking changes along with a heap of new functionality, I feel it's best to keep the existing plugin intact but deprecate it rather than replacing it with breaking changes.