Development #130
Merged
Development #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
GeorgWa
approved these changes
Jan 13, 2024
| """ | ||
| fragment.update_precursor_mz(self._precursor_df) | ||
|
|
||
| def update_precursor_mz(self): | ||
| def calc_and_clip_precursor_mz(self): |
There was a problem hiding this comment.
really good, I like that the clipping is mentioned and won't surprise users
| min_right_most_intensity = min_right_most_intensity, | ||
| ) | ||
|
|
||
|
|
||
| def calc_precursor_isotope(self, |
There was a problem hiding this comment.
If you like we can keep only one calc_precursor_isotope_intensity or calc_precursor_isotope so there's no redundancy.
There was a problem hiding this comment.
calc_precursor_isotope is now calc_precursor_isotope_info. My original thought is that maybe it is useful in AlphaDIA, but I think your calc_*_intensity is better in readability and memory-saving.
|
@GeorgWa If this PR does not disturb some AlphaDIA functionalities, we can them merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In spectral_library.base,
calc_precursor_isotopewill usecalc_precursor_isotope_intensity. It will be the default option for all speclib generation if isotopes are included.I also removed
multiprocessing=Trueparameter as it can be controled bymp_process_num>1. @GeorgWa Please be aware this change to alphadia.