Refactor readers iv #246
Open
Refactor readers iv #246
+291
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mschwoer
commented
Nov 19, 2024
| "[Phospho]", | ||
| "_(Phospho)", | ||
| "_[Phospho]", | ||
| ] |
There was a problem hiding this comment.
@jalew188 just by symmetry, I would expect (Phospho) here too?
There was a problem hiding this comment.
It should be, but I am not sure what is this testing for.
mschwoer
commented
Nov 19, 2024
| @@ -0,0 +1,113 @@ | |||
| """Utility functions for PSM readers.""" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to simplify the inheritance structure
self.csv_sepa ordinary variable