Config simplifications #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
force-pushed
the
config_simplifications
branch
from
160ece0 to
e5c903c
Compare
mschwoer
added
the
test:e2e
mschwoer
added
test:e2e
mschwoer
added
test:e2e
This reverts commit 45e22fa.
mschwoer
removed
the
test:e2e
mschwoer
commented
Feb 19, 2025
GeorgWa
approved these changes
Feb 19, 2025
# Conflicts: # gui/workflows/PeptideCentric.v1.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweaks to align UI and config (i.e. avoid that config will show a diff even though no UI parameter has been changed)
For both keys, I have questions @GeorgWa:
peptdeep_model_type: why isNoneandgenerictreated differently in code although docs say they mean the samechannel_filter: UI docs say "Leave empty to load all available channels.". Is this the behaviour of0?