Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip freeze #468

Closed

Conversation

mschwoer
Copy link
Collaborator

@mschwoer mschwoer commented Feb 13, 2025

closed in favour of #475 and MannLabs/alphashared#22


An idea how to fix requirements, as a ground for discussions. The idea is to avoid situations like this: #463

  • have a defined environment (Docker) to resolve the dependencies and create _requirements_freeze.txt

docker build -f Dockerfile.pipfreeze --progress=plain -t pipfreeze .
docker run -v ./requirements/:/app/output -t pipfreeze

  • use _requirements_freeze.txt for the stable installation

If one forgets to update _freeze.txt, this would be the error:

ERROR: Cannot install alphadia[stable]==1.9.3.dev2 because these package versions have conflicting dependencies.

The conflict is caused by:
alphadia[stable] 1.9.3.dev2 depends on ruff==0.9.1; extra == "stable"
alphadia[stable] 1.9.3.dev2 depends on ruff==0.9.2; extra == "stable"

could add a test that checks that prevents that error by checking that all versions defined in requirements.txt are actually exactly the same as in _requirements_freeze.txt (similiar to what we already have)

@mschwoer mschwoer changed the base branch from main to dependabot/pip/requirements/transformers-4.48.0 February 17, 2025 08:30
@mschwoer mschwoer closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant