Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interface to allow different learning rate schedulers #155

Merged
merged 3 commits into from
May 1, 2024
Merged

Update interface to allow different learning rate schedulers #155

merged 3 commits into from
May 1, 2024

Conversation

mo-sameh
Copy link
Collaborator

No description provided.

GeorgWa
GeorgWa approved these changes Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I think this addresses all comments from #154

peptdeep/model/model_interface.py Outdated Show resolved Hide resolved
peptdeep/model/model_interface.py Show resolved Hide resolved
@mo-sameh mo-sameh merged commit c19c65e into development May 1, 2024
6 checks passed
@mo-sameh mo-sameh deleted the custom-lr-schedule branch May 1, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

@jalew188 jalew188 jalew188 approved these changes

@mschwoer mschwoer Awaiting requested review from mschwoer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mo-sameh @jalew188 @GeorgWa