Draft refactor dataset #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaS92
reviewed
Sep 16, 2024
JuliaS92
reviewed
Sep 16, 2024
JuliaS92
reviewed
Sep 16, 2024
JuliaS92
reviewed
Sep 16, 2024
JuliaS92
reviewed
Sep 16, 2024
JuliaS92
reviewed
Sep 16, 2024
There was a problem hiding this comment.
This looks like we're going in the right direciton.
I am not sure if the Interface is maybe overengineering it at the moment. If not I would like to see the shared attributes documented here as well.
We should also try and reduce the number of attributes needed to be passed to Preprocess.
Also I think the metadata actually does not change anytime during batch correction.
JuliaS92
reviewed
Sep 17, 2024
JuliaS92
reviewed
Sep 17, 2024
JuliaS92
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts decoupling DataSet from its superclasses.
Also, simplifies DataSet class a bit, adds type hints.
Some code needed to be commented out, but was not used atm