Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature finder Implementation #23

Merged
merged 7 commits into from
Feb 4, 2024
Merged

Feature finder Implementation #23

merged 7 commits into from
Feb 4, 2024

Conversation

straussmaximilian
Copy link
Member

@straussmaximilian straussmaximilian commented Dec 23, 2023

FF Implementation - Draft

This is to integrate the AlphaPept Feature finding code.

Layout

alpharaw/
│
├── feature/                   # Source files
│   ├── centroids.py            # Connect centroids
│   └── finding.py          # API to call the FF
│   └── hills.py          # Hill Refinement
│   └── isotope_pattern.py          # Pre Isotope Patterns and Isotope Patterns from Hills
│   └── performance.py          # Helper function for performance, could be moved to AlphaBase at somre point

ToDO:

  • Port initial code
  • Get rid of AlphaPept settings and have them as arguments
  • Revise the performance function and remove CUDA functionality > used from AlphaTims
  • Use constants/ averagine model from alphabase > Used from AlphaPept for now
  • Make API more streamlined
  • Have integration test

Current Status: Working but somehow slower (?)

@straussmaximilian straussmaximilian marked this pull request as ready for review February 1, 2024 15:03
@straussmaximilian
Copy link
Member Author

This is now a fully working integration

  • This uses @threadpool from AlphaTims as a performance function, so it is dependent on alphatims
  • I removed the networkx dependency by having ChatGPT rewrite the required function. This worked surprisingly well
  • The notebook has some unit tests and a full integration test with the dataframe api
  • I had to copy some chemistry functions - this introduces some redundancy. Feel free to replace with existing code if you have..

Runtime for the full file on my MacBook: ~20 minutes

@straussmaximilian straussmaximilian added the enhancement New feature or request label Feb 1, 2024
@jalew188
Copy link
Collaborator

jalew188 commented Feb 4, 2024

@straussmaximilian Thank you. It looks good. On windows, the speed seems quite slow. We can fix this later.

@jalew188 jalew188 merged commit a3a7103 into development Feb 4, 2024
6 checks passed
@mschwoer mschwoer deleted the feature_finder branch May 16, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants