Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

53 docs init pattern #66

Merged
merged 5 commits into from
Jun 28, 2024
Merged

53 docs init pattern #66

merged 5 commits into from
Jun 28, 2024

Conversation

jalew188
Copy link
Collaborator

For a class, move init params into init method, instead of the class definition.

mschwoer
mschwoer reviewed Jun 26, 2024
View reviewed changes
alpharaw/thermo.py Show resolved Hide resolved
alpharaw/wrappers/alphatims_wrapper.py Outdated Show resolved Hide resolved
alpharaw/wrappers/alphatims_wrapper.py Show resolved Hide resolved
@jalew188 jalew188 requested a review from mschwoer June 26, 2024 11:02
GeorgWa
GeorgWa approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jalew188 jalew188 merged commit efdb5fe into development Jun 28, 2024
2 checks passed
@jalew188 jalew188 deleted the 53-docs-init-pattern branch June 28, 2024 15:24
@jalew188 jalew188 restored the 53-docs-init-pattern branch June 28, 2024 15:25
@jalew188 jalew188 deleted the 53-docs-init-pattern branch June 28, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

@mschwoer mschwoer Awaiting requested review from mschwoer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jalew188 @GeorgWa @mschwoer