Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matterverse provider #101

Merged
merged 9 commits into from
Aug 15, 2024

Conversation

JiQi535
Copy link
Contributor

@JiQi535 JiQi535 commented Mar 19, 2024

The base URL is not yet activated.

It will be linked to: https://optimade-matterverse-ai-43429a548b75.herokuapp.com/.

ml-evs and others added 5 commits September 12, 2022 17:29
Co-authored-by: Ji Qi <JiQi535@users.noreply.github.com>
Co-authored-by: Christen Xie <christen03@users.noreply.github.com>
Co-authored-by: Christen <99223047+christen03@users.noreply.github.com>
@JiQi535 JiQi535 marked this pull request as draft March 19, 2024 03:56
Co-authored-by: Rickard Armiento <gitcommits@armiento.net>
@JiQi535
Copy link
Contributor Author

JiQi535 commented Mar 19, 2024

A quick update: I have linked the base url to the desired domain, and it is working. https://optimade.matterverse.ai/

I believe the only step left is to rename/add some fields in our mongodb collection of matterverse.ai. Then this PR can be merged. @ml-evs Let me know if my understanding is correct. Thanks!

@ml-evs
Copy link
Member

ml-evs commented Apr 7, 2024

A quick update: I have linked the base url to the desired domain, and it is working. https://optimade.matterverse.ai/

I believe the only step left is to rename/add some fields in our mongodb collection of matterverse.ai. Then this PR can be merged. @ml-evs Let me know if my understanding is correct. Thanks!

Hi @JiQi535, sorry for the delay here, I tried the link a while ago and saw that it was not working, and that still seems to be the case. Is the link in the PR definitely the right one?

@JiQi535
Copy link
Contributor Author

JiQi535 commented Jun 10, 2024

A quick update: I have linked the base url to the desired domain, and it is working. https://optimade.matterverse.ai/
I believe the only step left is to rename/add some fields in our mongodb collection of matterverse.ai. Then this PR can be merged. @ml-evs Let me know if my understanding is correct. Thanks!

Hi @JiQi535, sorry for the delay here, I tried the link a while ago and saw that it was not working, and that still seems to be the case. Is the link in the PR definitely the right one?

Hi @ml-evs, it should be working now!

@JiQi535 JiQi535 marked this pull request as ready for review June 10, 2024 05:07
@ml-evs ml-evs changed the title Ml evs/add matterverse Add matterverse provider Jun 10, 2024
ml-evs
ml-evs previously approved these changes Jun 10, 2024
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @JiQi535, I think this is now ready to merge! You will then be able to check the provider dashboard for automated validator runs which might help iron out any remaining bugs.

@ml-evs
Copy link
Member

ml-evs commented Jun 10, 2024

For some reason the netlify preview isn't working here, but the content looks fine to me

@ml-evs
Copy link
Member

ml-evs commented Jun 10, 2024

We've realised that there is an SSL issue on our end which we will try to resolve before merging this PR.

@ml-evs ml-evs changed the base branch from ml-evs/add_matterverse to master June 12, 2024 07:56
@ml-evs ml-evs dismissed their stale review June 12, 2024 07:56

The base branch was changed.

@ml-evs
Copy link
Member

ml-evs commented Jun 24, 2024

IMO this is ready now that we have resolved CI issues (in #103).

@ml-evs ml-evs requested review from rartino and ml-evs June 24, 2024 16:53
@ml-evs
Copy link
Member

ml-evs commented Aug 14, 2024

Seems like there were no objections to this being merged, and it does not seem fair to hold up this PR based on the lack of consensus in Materials-Consortia/OPTIMADE#455, so I will merge this at the end of the week unless there are any final comments.

@ml-evs ml-evs merged commit e90caba into Materials-Consortia:master Aug 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants