Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing CI failures: try to wait directly for the info endpoint #103

Closed
wants to merge 2 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jun 12, 2024

No description provided.

merkys
merkys previously approved these changes Jun 12, 2024
Copy link
Member

@merkys merkys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You surely have tested this and there is no need to nitpick, but out of pure interest: why did not it work without /v1/info?

@ml-evs
Copy link
Member Author

ml-evs commented Jun 12, 2024

Actually this PR is the test... I cannot reproduce these issues locally. Basically it seems that the "base URL" of the deployment comes up much faster than static files we are mounting, and then the tests fail at the first step because /info does not exist. So still some work is needed here...

@ml-evs
Copy link
Member Author

ml-evs commented Jun 24, 2024

I held off merging this during the workshop, as it seems like netlify have resolved whatever issue was affecting us. I'll close for now but if we run into any more issues then this is the likely culprit!

@ml-evs ml-evs closed this Jun 24, 2024
@ml-evs ml-evs mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants