Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @james-bruten-mo
Code Reviewer: @Pierre-siddall
This adds the fortitude linter to the test suite, and enables one rule to run to demonstrate basic functionality. Subsequent branches will add more rules and testing.
Associated with MetOffice/lfric_core#217
This addition will mean Fortitude will run when the "scripts"/ "developer"/ "all" groups, or "fortitude_linter" group itself is run with the Cylc test suite.
The rule added here can be referenced Fortitude documentation website here: https://fortitude.readthedocs.io/en/stable/rules/trailing-whitespace/
For reference, these are some example outputs and errors from when fortitude runs:
No errors output:
https://cylchub/services/cylc-review/view/lucy.gordon?&suite=lapps_add_gh_no_errors%2Frun10&no_fuzzy_time=0&path=log/job/1/fortitude_linter/01/job.out
One lint error outputs:
https://cylchub/services/cylc-review/view/lucy.gordon?&suite=lapps_add_gh_no_errors%2Frun8&no_fuzzy_time=0&path=log/job/1/fortitude_linter/01/job.err
Non-lint error outputs:
https://cylchub/services/cylc-review/view/lucy.gordon?&suite=lapps_add_gh_no_errors%2Frun9&no_fuzzy_time=0&path=log/job/1/fortitude_linter/01/job.err
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - lapps_add_gh_no_errors/run5
Suite Information
Task Information
✅ succeeded tasks - 1457
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review