-
Notifications
You must be signed in to change notification settings - Fork 28
Adding fortitude #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mo-lucy-gordon
wants to merge
11
commits into
MetOffice:main
Choose a base branch
from
mo-lucy-gordon:adding_fortitude
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding fortitude #217
+137
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re into adding_fortitude "merge in updates from origin"
Contributor
Author
|
I just spotted a print message I forgot to correct the formatting for so added one more commit to fix it. |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @james-bruten-mo
Code Reviewer: @Pierre-siddall
This adds the fortitude linter to the test suite and enables one rule to run to demonstrate basic functionality. Subsequent branches will add more rules and testing.
Associated with MetOffice/lfric_apps#150
This addition will mean Fortitude will run when the "scripts", "developer", "all" or "fortitude_linter" group itself is run with the Cylc test suite.
The rule added here can be referenced Fortitude documentation website here: https://fortitude.readthedocs.io/en/stable/rules/use-all/
For reference, these are some example outputs and errors from when fortitude runs:
No errors, run with group=fortitude_linter
https://cylchub/services/cylc-review/cycles/lucy.gordon?&suite=lcore_add_gh_no_errors2%2Frun3
...and with scripts:
https://cylchub/services/cylc-review/taskjobs/lucy.gordon?&suite=lcore_add_gh_no_errors2%2Frun8&cycles=1&task_status=expired&task_status=succeeded
Lint errors in one repo, run with group=fortitude_linter:
https://cylchub/services/cylc-review/view/lucy.gordon?&suite=lcore_add_gh_no_errors2%2Frun5&no_fuzzy_time=0&path=log/job/1/fortitude_linter/01/job.err
Non-lint errors in most repos, and no errors in one repo, run with group=fortitude_linter:
https://cylchub/services/cylc-review/view/lucy.gordon?&suite=lcore_add_gh_no_errors2%2Frun6&no_fuzzy_time=0&path=log/job/1/fortitude_linter/01/job.err
https://cylchub/services/cylc-review/view/lucy.gordon?&suite=lcore_add_gh_no_errors2%2Frun6&no_fuzzy_time=0&path=log/job/1/fortitude_linter/01/job.out
Sci/Tech Reviewer:
Code Reviewer:
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
using this branch
acceptable (e.g. kgo changes)
tests, unit tests, etc.)
and have been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_core - lcore_add_gh_no_errors2/run7
Suite Information
Task Information
✅ succeeded tasks - 373
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
interface, optimisation scripts, LFRic data structure code) then please
contact the
tooscollabdevteam@metoffice.gov.uk
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review