Skip to content

Conversation

@mo-lucy-gordon
Copy link
Contributor

@mo-lucy-gordon mo-lucy-gordon commented Jan 14, 2026

PR Summary

Sci/Tech Reviewer: @james-bruten-mo
Code Reviewer: @Pierre-siddall

This adds the fortitude linter to the test suite and enables one rule to run to demonstrate basic functionality. Subsequent branches will add more rules and testing.

Associated with MetOffice/lfric_apps#150

This addition will mean Fortitude will run when the "scripts", "developer", "all" or "fortitude_linter" group itself is run with the Cylc test suite.

The rule added here can be referenced Fortitude documentation website here: https://fortitude.readthedocs.io/en/stable/rules/use-all/

For reference, these are some example outputs and errors from when fortitude runs:

Sci/Tech Reviewer:
Code Reviewer:

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's
    style guidelines
  • Comments have been included that aid understanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite
    using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system
    tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource
    and have been allocated to an appropriate testing group (i.e. the
    developer tests are for jobs which use a small amount of compute resource
    and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - lcore_add_gh_no_errors2/run7

Suite Information

Item Value
Suite Name lcore_add_gh_no_errors2/run7
Suite User lucy.gordon
Workflow Start 2026-01-14T11:46:12
Groups Run all
Dependency Reference Main Like
lfric_core mo-lucy-gordon/lfric_core@adding_fortitude False
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True

Task Information

✅ succeeded tasks - 373

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel
    interface, optimisation scripts, LFRic data structure code) then please
    contact the
    tooscollabdevteam@metoffice.gov.uk

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-required CLA signature is required for this PR. label Jan 14, 2026
@github-actions github-actions bot added cla-signed This contributor has signed the CLA. and removed cla-required CLA signature is required for this PR. labels Jan 14, 2026
@mo-lucy-gordon mo-lucy-gordon marked this pull request as ready for review January 14, 2026 18:25
@mo-lucy-gordon mo-lucy-gordon removed the request for review from mike-hobson January 15, 2026 10:45
@mo-lucy-gordon
Copy link
Contributor Author

I just spotted a print message I forgot to correct the formatting for so added one more commit to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed This contributor has signed the CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant