Timing Mod wrapper rewrite #201
Conversation
jedbakerMO
requested review from
EdHone,
MatthewHambley,
andrewcoughtrie,
mike-hobson and
stevemullerworth
as code owners
jedbakerMO
requested review from
mo-rickywong
and removed request for
EdHone,
MatthewHambley,
andrewcoughtrie,
mike-hobson and
stevemullerworth
christophermaynard
left a comment
christophermaynard
left a comment
There was a problem hiding this comment.
Tested and all working
Moved contributor name entry in CONTRIBUTORS.md to be alphabetical according to github username.
|
I note that there is no test suite item actually running using vernier. There is nothing on core or apps as far as I can see that will fall over if this profiling functionality breaks. LFRic Core test suite is built using VERNIER but none of the applications are instrumented to provide any profiler output, i.e. init_timing doesn't seem to be called in any of the apps. The lfric-apps Rose test suite runs with the old legacy timer, so again no test suite tasks are being run exercising the use of VERNIER. Is there a task in the test suites that use vernier? If not, please instrument at least 1 ont the LFRIc Core apps to use profiling, I'd suggest io_demo. |
Io Demo has had the timing wrapper implemented and subroutine_timers turned on in the rose config. This has been tested succesfully with Vernier outputs. |
|
Have check that this works with io_demo, happy to approve |
3 participants
PR Summary
Sci/Tech Reviewer: @christophermaynard
Code Reviewer: @mo-rickywong
This PR is the github migration of Trac : lfric_core#4669
It replaces all timer calls throughout LFRic Apps (in the linked PR) and LFRic Core with the new timing wrapper. The timing wrapper can use either the current timer or Vernier, depending on suite configuration.
linked MetOffice/lfric_apps#80
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
using this branch
acceptable (e.g. kgo changes)
tests, unit tests, etc.)
and have been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_core - timing_mod_core_updated/run1
Suite Information
Task Information
✅ succeeded tasks - 370
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
interface, optimisation scripts, LFRic data structure code) then please
contact the
tooscollabdevteam@metoffice.gov.uk
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review