Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Typescript type coverage Views Folder part 1 #10206

Closed
1 of 9 tasks
tommasini opened this issue Jul 1, 2024 · 1 comment · Fixed by #10665
Closed
1 of 9 tasks

Chore: Typescript type coverage Views Folder part 1 #10206

tommasini opened this issue Jul 1, 2024 · 1 comment · Fixed by #10665
Assignees
Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 team-mobile-platform type-tech-debt Technical debt

Comments

@tommasini
Copy link
Contributor

tommasini commented Jul 1, 2024

What is this about?

The following strategy to get this done without causing friction to others work will be:

Start to uncomment, commented lines at tsconfig.lint.json
Fix the flagged typescript issues by yarn lint:tsc of the following chunk of files
Revert the uncommented lines at tsconfig.lint.json
Open a PR against the issue

Views Folder part 1

     3  app/components/Views/AccountConnect/AccountConnect.tsx:98
     2  app/components/Views/AccountPermissions/AccountPermissions.tsx:135
     1  app/components/Views/AccountPermissions/AccountPermissionsConnected/AccountPermissionsConnected.tsx:80
     2  app/components/Views/AccountPermissions/AccountPermissionsRevoke/AccountPermissionsRevoke.tsx:169
     3  app/components/Views/AddAsset/AddAsset.tsx:86
     3  app/components/Views/AssetDetails/index.tsx:273
     2  app/components/Views/BrowserUrlModal/BrowserUrlModal.tsx:105

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@tommasini
Copy link
Contributor Author

@jpcloureiro If you want you can begin from here if you feel that it will save you time!

@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 team-mobile-platform type-tech-debt Technical debt
Projects
None yet
4 participants