Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix TS errors for some views files #10290

Closed
wants to merge 13 commits into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Description

The aim of this chore is to achieve 100% TypeScript file coverage by fixing all TypeScript issues in the specified files.

app/components/Views/AccountConnect/AccountConnect.tsx
app/components/Views/AccountPermissions/AccountPermissions.tsx
app/components/Views/AccountPermissions/AccountPermissionsConnected/AccountPermissionsConnected.tsx
app/components/Views/AccountPermissions/AccountPermissionsRevoke/AccountPermissionsRevoke.tsx
app/components/Views/AddAsset/AddAsset.tsx
app/components/Views/AssetDetails/index.tsx
app/components/Views/BrowserUrlModal/BrowserUrlModal.tsx

Related issues

#10206

Manual testing steps

  • yarn lint:tsc should yield no new or unexpected TypeScript errors

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch; run the app; test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@devin-ai-integration devin-ai-integration bot added team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 12, 2024
@metamaskbot metamaskbot added the team-ai AI team (for the Devin AI bot) label Jul 12, 2024
Copy link

sonarcloud bot commented Jul 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.9% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@tommasini tommasini linked an issue Jul 15, 2024 that may be closed by this pull request
9 tasks
@tommasini tommasini changed the title chore: Fix TS errors for some app/components file chore: Fix TS errors for some views files Jul 16, 2024
@sethkfman sethkfman closed this Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Chore: Typescript type coverage Views Folder part 1
2 participants