Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: typescript hooks and base folder coverage #10253

Merged
merged 4 commits into from
Jul 11, 2024
Merged

chore: typescript hooks and base folder coverage #10253

merged 4 commits into from
Jul 11, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jul 5, 2024 •
edited
Loading

Description

PR to typescript fix the hooks and base folders files.

Related issues

Fixes: #10201

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Jul 9, 2024
@tommasini tommasini marked this pull request as ready for review July 9, 2024 17:18
@tommasini tommasini requested a review from a team as a code owner July 9, 2024 17:18
@tommasini tommasini self-assigned this Jul 9, 2024
Cal-L
Cal-L reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

app/components/hooks/DisplayName/useTokenList.ts Outdated Show resolved Hide resolved
app/components/hooks/useTokenBalancesController/useTokenBalancesController.ts Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Cal-L
Cal-L approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit 84f589c into main Jul 11, 2024
32 checks passed
@tommasini tommasini deleted the chore/ts-coverage-hooks-base-folder branch July 11, 2024 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 11, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@tommasini tommasini

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.28.0 Issue or pull request that will be included in release 7.28.0 team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Typescript type coverage Hooks and Base folders
3 participants
@tommasini @Cal-L @metamaskbot