chore: typescript hooks and base folder coverage

app/components/Approvals/InstallSnapApproval/components/InstallSnapPermissionsRequest/test/InstallSnapPermissionsRequest.test.tsx

@@ -52,6 +52,7 @@ describe('InstallSnapPermissionsRequest', () => {
         approvalRequest={installSnapDataApprovalRequest}
         onConfirm={onConfirm}
         onCancel={onCancel}
+        snapId="mockId"
       />,
     );
     const permissionCells = getAllByTestId(SNAP_PERMISSION_CELL);

app/components/Base/Alert.stories.tsx

@@ -28,7 +28,9 @@ storiesOf('Components / Base / Alert', module)
         small={boolean('small', false)}
         renderIcon={
           renderIconKnob
-            ? () => <EvilIcons name="bell" style={styles.alertIcon} size={20} />
+            ? //@ts-expect-error needs to be replaced by Icon of component library, EvilIcons are deprecated
+              // All this component is deprecated so it should be replaced and removed
+              () => <EvilIcons name="bell" style={styles.alertIcon} size={20} />
             : () => null
         }
         onPress={action('onPress')}

app/components/Base/Alert.tsx

@@ -141,7 +141,11 @@ const Alert = ({
             onPress={onDismiss}
             hitSlop={{ top: 20, left: 20, right: 20, bottom: 20 }}
           >
-            <IonicIcon name="ios-close" style={styles.closeIcon} size={30} />
+            {
+              //@ts-expect-error needs to be replaced by Icon of component library, IonicIcon are deprecated
+              // All this component is deprecated so it should be replaced and removed
+              <IonicIcon name="ios-close" style={styles.closeIcon} size={30} />
+            }
           </TouchableOpacity>
         </View>
       )}

app/components/hooks/useAddressBalance/useAddressBalance.ts

@@ -65,6 +65,7 @@ const useAddressBalance = (
 
   useEffect(() => {
     const setBalance = () => {
+      if (!address) return;
       const parsedTicker = getTicker(ticker);
       const checksumAddress = safeToChecksumAddress(address);
       if (!checksumAddress) {

app/components/hooks/useBluetoothPermissions.test.ts

@@ -51,8 +51,8 @@ describe('useBluetoothPermissions', () => {
   });
 
   it('grants permissions on iOS', async () => {
-    Device.isIos.mockReturnValue(true);
-    request.mockResolvedValue(RESULTS.GRANTED);
+    (Device.isIos as jest.Mock).mockReturnValue(true);
+    (request as jest.Mock).mockResolvedValue(RESULTS.GRANTED);
 
     const { result, waitForNextUpdate } = renderHook(() =>
       useBluetoothPermissions(),
@@ -64,8 +64,8 @@ describe('useBluetoothPermissions', () => {
   });
 
   it('denies permissions on iOS', async () => {
-    Device.isIos.mockReturnValue(true);
-    request.mockResolvedValue(RESULTS.DENIED);
+    (Device.isIos as jest.Mock).mockReturnValue(true);
+    (request as jest.Mock).mockResolvedValue(RESULTS.DENIED);
 
     const { result, waitForNextUpdate } = renderHook(() =>
       useBluetoothPermissions(),
@@ -79,9 +79,9 @@ describe('useBluetoothPermissions', () => {
   });
 
   it('grants permissions on Android 12+', async () => {
-    Device.isAndroid.mockReturnValue(true);
-    getSystemVersion.mockReturnValue('12');
-    requestMultiple.mockResolvedValue({
+    (Device.isAndroid as jest.Mock).mockReturnValue(true);
+    (getSystemVersion as jest.Mock).mockReturnValue('12');
+    (requestMultiple as jest.Mock).mockResolvedValue({
       [PERMISSIONS.ANDROID.BLUETOOTH_CONNECT]: RESULTS.GRANTED,
       [PERMISSIONS.ANDROID.BLUETOOTH_SCAN]: RESULTS.GRANTED,
     });
@@ -96,9 +96,9 @@ describe('useBluetoothPermissions', () => {
   });
 
   it('denies permissions on Android 12+', async () => {
-    Device.isAndroid.mockReturnValue(true);
-    getSystemVersion.mockReturnValue('12');
-    requestMultiple.mockResolvedValue({
+    (Device.isAndroid as jest.Mock).mockReturnValue(true);
+    (getSystemVersion as jest.Mock).mockReturnValue('12');
+    (requestMultiple as jest.Mock).mockResolvedValue({
       [PERMISSIONS.ANDROID.BLUETOOTH_CONNECT]: RESULTS.DENIED,
       [PERMISSIONS.ANDROID.BLUETOOTH_SCAN]: RESULTS.DENIED,
     });
@@ -115,9 +115,9 @@ describe('useBluetoothPermissions', () => {
   });
 
   it('grants permissions on Android <12', async () => {
-    Device.isAndroid.mockReturnValue(true);
-    getSystemVersion.mockReturnValue('11');
-    request.mockResolvedValue(RESULTS.GRANTED);
+    (Device.isAndroid as jest.Mock).mockReturnValue(true);
+    (getSystemVersion as jest.Mock).mockReturnValue('11');
+    (request as jest.Mock).mockResolvedValue(RESULTS.GRANTED);
 
     const { result, waitForNextUpdate } = renderHook(() =>
       useBluetoothPermissions(),
@@ -129,9 +129,9 @@ describe('useBluetoothPermissions', () => {
   });
 
   it('denies permissions on Android <12', async () => {
-    Device.isAndroid.mockReturnValue(true);
-    getSystemVersion.mockReturnValue('11');
-    request.mockResolvedValue(RESULTS.DENIED);
+    (Device.isAndroid as jest.Mock).mockReturnValue(true);
+    (getSystemVersion as jest.Mock).mockReturnValue('11');
+    (request as jest.Mock).mockResolvedValue(RESULTS.DENIED);
 
     const { result, waitForNextUpdate } = renderHook(() =>
       useBluetoothPermissions(),
@@ -145,9 +145,9 @@ describe('useBluetoothPermissions', () => {
   });
 
   it('checks permissions when app state changes to active', async () => {
-    Device.isAndroid.mockReturnValue(true);
-    getSystemVersion.mockReturnValue('12');
-    requestMultiple.mockResolvedValue({
+    (Device.isAndroid as jest.Mock).mockReturnValue(true);
+    (getSystemVersion as jest.Mock).mockReturnValue('12');
+    (requestMultiple as jest.Mock).mockResolvedValue({
       [PERMISSIONS.ANDROID.BLUETOOTH_CONNECT]: RESULTS.GRANTED,
       [PERMISSIONS.ANDROID.BLUETOOTH_SCAN]: RESULTS.GRANTED,
     });
@@ -158,17 +158,17 @@ describe('useBluetoothPermissions', () => {
     expect(requestMultiple).toHaveBeenCalledTimes(1);
 
     act(() => {
-      AppState.addEventListener.mock.calls[0][1]('active');
+      (AppState.addEventListener as jest.Mock).mock.calls[0][1]('active');
     });
 
     //checkPermission run again when app state changes to active
     expect(requestMultiple).toHaveBeenCalledTimes(2);
   });
 
   it('does not check permissions when app state changes to background', async () => {
-    Device.isAndroid.mockReturnValue(true);
-    getSystemVersion.mockReturnValue('12');
-    requestMultiple.mockResolvedValue({
+    (Device.isAndroid as jest.Mock).mockReturnValue(true);
+    (getSystemVersion as jest.Mock).mockReturnValue('12');
+    (requestMultiple as jest.Mock).mockResolvedValue({
       [PERMISSIONS.ANDROID.BLUETOOTH_CONNECT]: RESULTS.GRANTED,
       [PERMISSIONS.ANDROID.BLUETOOTH_SCAN]: RESULTS.GRANTED,
     });
@@ -179,17 +179,17 @@ describe('useBluetoothPermissions', () => {
     expect(requestMultiple).toHaveBeenCalledTimes(1);
 
     act(() => {
-      AppState.addEventListener.mock.calls[0][1]('inactive');
+      (AppState.addEventListener as jest.Mock).mock.calls[0][1]('inactive');
     });
 
     //checkPermission does not run when app state changes to inactive
     expect(requestMultiple).toHaveBeenCalledTimes(1);
   });
 
   it('grants permissions when getSystemVersion is null', async () => {
-    Device.isAndroid.mockReturnValue(true);
-    getSystemVersion.mockReturnValue(null);
-    request.mockResolvedValue(RESULTS.GRANTED);
+    (Device.isAndroid as jest.Mock).mockReturnValue(true);
+    (getSystemVersion as jest.Mock).mockReturnValue(null);
+    (request as jest.Mock).mockResolvedValue(RESULTS.GRANTED);
 
     const { result, waitForNextUpdate } = renderHook(() =>
       useBluetoothPermissions(),
@@ -201,9 +201,9 @@ describe('useBluetoothPermissions', () => {
   });
 
   it('grants permissions when getSystemVersion return is not a number', async () => {
-    Device.isAndroid.mockReturnValue(true);
-    getSystemVersion.mockReturnValue('adbd');
-    request.mockResolvedValue(RESULTS.GRANTED);
+    (Device.isAndroid as jest.Mock).mockReturnValue(true);
+    (getSystemVersion as jest.Mock).mockReturnValue('adbd');
+    (request as jest.Mock).mockResolvedValue(RESULTS.GRANTED);
 
     const { result, waitForNextUpdate } = renderHook(() =>
       useBluetoothPermissions(),

app/components/hooks/useThunkDispatch.ts

@@ -1,16 +1,12 @@
+import { ThunkAction as ReduxThunkAction, ThunkDispatch } from 'redux-thunk';
 import { useDispatch } from 'react-redux';
-import { AnyAction, Store } from 'redux';
+import { AnyAction } from 'redux';
+import { RootState } from '../../reducers';
 
-// TODO: Replace "any" with type
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-type Dispatch = Store<any, AnyAction>['dispatch'];
-// TODO: Replace "any" with type
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-type GetState = Store<any, AnyAction>['getState'];
-
-export type ThunkAction = (dispatch: Dispatch, getState: GetState) => void;
+export type ThunkAction = ReduxThunkAction<void, RootState, unknown, AnyAction>;
 
 function useThunkDispatch() {
-  return useDispatch<(thunkAction: ThunkAction) => void>();
+  return useDispatch<ThunkDispatch<RootState, unknown, AnyAction>>();
 }
+
 export default useThunkDispatch;

app/components/hooks/useTokenBalance.tsx

@@ -1,6 +1,6 @@
 import { useState, useEffect, Dispatch, SetStateAction } from 'react';
 import Engine from '../../core/Engine';
-import { BN } from '@metamask/assets-controllers';
+import { BN } from 'ethereumjs-util';
 
 /**
  * Hook to handle the balance of ERC20 tokens

app/components/hooks/useTokenBalancesController/useTokenBalancesController.ts

@@ -1,11 +1,10 @@
 import { useSelector } from 'react-redux';
 import { isEqual } from 'lodash';
 import { ControllerHookType } from '../controllerHook.types';
-import { BN } from 'ethereumjs-util';
 import { selectContractBalances } from '../../../selectors/tokenBalancesController';
 
 interface TokenBalances {
-  [address: string]: BN;
+  [address: string]: string;
 }
 
 const useTokenBalancesController = (): ControllerHookType<TokenBalances> => {

app/declarations.d.ts

@@ -272,3 +272,8 @@ declare module 'react-native-vector-icons/Zocial' {
    */
   export default class Zocial extends ZocialIconType {}
 }
+
+declare module '@metamask/contract-metadata' {
+  const content: Record<string, TokenListToken>;
+  export default content;
+}