Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: addressed lint issues #11194

Merged
merged 96 commits into from
Oct 22, 2024
Merged

chore: addressed lint issues #11194

merged 96 commits into from
Oct 22, 2024
+886 −638

Conversation

Daniel-Cross
Copy link
Contributor

@Daniel-Cross Daniel-Cross commented Sep 13, 2024 •
edited
Loading

Description

A PR that addresses all 50 current linting issues found in the repo when running yarn lint

Related issues

Fixes:

  1. Run yarn lint and see there are no linting issues remaining.
  2. Run yarn test:unit and see all tests pass.

Manual testing steps

Screenshots/Recordings

Before

Screenshot 2024-09-13 at 14 03 28

After

Screenshot 2024-09-13 at 14 01 40 Screenshot 2024-09-13 at 14 02 28

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Daniel-Cross Daniel-Cross added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 13, 2024
@Daniel-Cross Daniel-Cross self-assigned this Sep 13, 2024
@Daniel-Cross Daniel-Cross linked an issue Sep 13, 2024 that may be closed by this pull request
Address ESlint warnings #11100
Closed
9 tasks
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 13, 2024
@Daniel-Cross Daniel-Cross removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 13, 2024
@Daniel-Cross Daniel-Cross changed the title addressed lint issues chore: addressed lint issues Sep 13, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 13, 2024
@Daniel-Cross Daniel-Cross added Run Smoke E2E Triggers smoke e2e on Bitrise and removed INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5396b15
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/97c93ccc-d3fa-464e-894c-6cc57ab41f18

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Daniel-Cross Daniel-Cross added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4e9baf6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b3667c34-1ec9-4681-9b94-60a40254d567

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Daniel-Cross Daniel-Cross marked this pull request as ready for review September 17, 2024 10:44
@Daniel-Cross Daniel-Cross requested a review from a team as a code owner September 17, 2024 10:44
Daniel-Cross and others added 2 commits October 18, 2024 22:09
@Daniel-Cross Daniel-Cross added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 757c8ef
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7b95ab15-a500-4426-837e-e9d7860ad79b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Daniel-Cross Daniel-Cross added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 54b4f59
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53a84704-8231-4e2a-9cbe-20639f08a1e7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

jpuri
jpuri approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in files owned by confirmations team look good.

andreahaku
andreahaku approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.4% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

ccharly
ccharly approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for core/Encryptor test changes, thanks!

@Daniel-Cross Daniel-Cross added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit ffec4fd Oct 22, 2024
36 of 37 checks passed
@Daniel-Cross Daniel-Cross deleted the 11100-address-eslint-warnings branch October 22, 2024 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston left review comments

@tommasini tommasini tommasini left review comments

@ccharly ccharly ccharly approved these changes

@jpuri jpuri jpuri approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@andreahaku andreahaku andreahaku approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@abretonc7s abretonc7s abretonc7s approved these changes

@infiniteflower infiniteflower infiniteflower approved these changes

@sethkfman sethkfman sethkfman left review comments

Assignees

@Daniel-Cross Daniel-Cross

Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address ESlint warnings