Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: addressed lint issues #11194

Merged
merged 96 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
1c8ac49
addressed lint issues
Daniel-Cross Sep 13, 2024
7ab145b
fixed conflicts
Daniel-Cross Sep 13, 2024
5396b15
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 16, 2024
4a128c8
C
Daniel-Cross Sep 16, 2024
f53d72f
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 16, 2024
f4a42dc
addressed some Sentry issues in ChoosePassword
Daniel-Cross Sep 16, 2024
0ff761e
removed unused code in resetPassword
Daniel-Cross Sep 16, 2024
428af73
resolved conflicts
Daniel-Cross Sep 16, 2024
95acf7b
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 16, 2024
e55b8b3
made some changed to the duplicate code in reset password
Daniel-Cross Sep 16, 2024
4e9baf6
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 17, 2024
b56c460
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 17, 2024
63a5fa0
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 17, 2024
27ea227
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 17, 2024
9a7fea6
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 18, 2024
0904da6
revert project file
Daniel-Cross Sep 18, 2024
62d51f7
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 18, 2024
349121f
fixed conflicts
Daniel-Cross Sep 18, 2024
40060cd
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 19, 2024
93f841c
removed unnecessary or case
Daniel-Cross Sep 19, 2024
f6db0c9
added missed import
Daniel-Cross Sep 19, 2024
4c7522b
fixed import path
Daniel-Cross Sep 19, 2024
2a80734
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 19, 2024
988cb3e
updated import path
Daniel-Cross Sep 19, 2024
7d9fa7c
merged conflicts
Daniel-Cross Sep 20, 2024
c8bd1cd
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 20, 2024
a2fa5d4
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 20, 2024
78f755b
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 20, 2024
ae32fd4
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 23, 2024
92ddc5f
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 23, 2024
9b98d61
merged main
Daniel-Cross Sep 23, 2024
3974da3
fixed duplicate route
Daniel-Cross Sep 23, 2024
88becf9
revert project file
Daniel-Cross Sep 23, 2024
aa43373
merged main
Daniel-Cross Sep 23, 2024
b0e0144
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 25, 2024
7efcca3
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 25, 2024
a27dd11
reverted project file
Daniel-Cross Sep 25, 2024
dbc5afb
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 25, 2024
cd2253b
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 25, 2024
363060d
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 26, 2024
9b02739
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Sep 30, 2024
4609706
fixed linting issues and restored test
Daniel-Cross Oct 1, 2024
66b8dd7
fixed conflict
Daniel-Cross Oct 1, 2024
d23fd77
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 1, 2024
c11ea8f
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 1, 2024
ecea5cb
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 1, 2024
90128b7
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 2, 2024
2506870
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 2, 2024
72d9545
fixed conflicts
Daniel-Cross Oct 2, 2024
13fafb8
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 3, 2024
77913fb
fixed conflicts
Daniel-Cross Oct 8, 2024
96cd5ea
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 8, 2024
04cc021
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 8, 2024
1c8a96d
fixed conflicts
Daniel-Cross Oct 9, 2024
f041ad2
addressed some lint issues
Daniel-Cross Oct 9, 2024
a704b8b
fixed some more issues
Daniel-Cross Oct 9, 2024
356d0df
added eslint ignore rule
Daniel-Cross Oct 9, 2024
d7e6687
updated eslint rules
Daniel-Cross Oct 9, 2024
05f73c7
removed usecallbacks
Daniel-Cross Oct 9, 2024
bb1b461
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 9, 2024
3bf825e
resolved lint issues
Daniel-Cross Oct 9, 2024
7a87fca
added value to function
Daniel-Cross Oct 9, 2024
812e442
removed QR scanner
Daniel-Cross Oct 9, 2024
5b2c13c
revert smart transactions
Daniel-Cross Oct 9, 2024
1d7949b
changed some files
Daniel-Cross Oct 9, 2024
117fa40
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 9, 2024
a100198
reverted some files to fix tests
Daniel-Cross Oct 9, 2024
037a750
reverted gas update file
Daniel-Cross Oct 9, 2024
ad6f270
reverted views
Daniel-Cross Oct 9, 2024
997a12c
added new lint rule
Daniel-Cross Oct 9, 2024
874d284
added lint rule
Daniel-Cross Oct 9, 2024
5fbfe8b
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 9, 2024
e1be978
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 10, 2024
eeb27cb
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 10, 2024
2619c92
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 11, 2024
6c2e3bf
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 11, 2024
7d66bac
rewrote some of the components to fix the render issues
Daniel-Cross Oct 13, 2024
fa595ca
reworked linting issues to be compliant with linter
Daniel-Cross Oct 14, 2024
2f4e6f1
resolved conflicts
Daniel-Cross Oct 14, 2024
c327625
updated snapshots
Daniel-Cross Oct 14, 2024
f114fe9
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 14, 2024
15f653c
reverted 1559 update file
Daniel-Cross Oct 14, 2024
f49f842
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 14, 2024
aeb1c3c
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 14, 2024
19b7de9
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 15, 2024
1499fc5
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 15, 2024
72718b0
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 16, 2024
618ddab
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 16, 2024
fb2d46b
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 17, 2024
ea1fa11
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 17, 2024
008a5c4
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 18, 2024
2142c2f
Update app/components/Nav/Main/MainNavigator.js
Daniel-Cross Oct 18, 2024
757c8ef
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 21, 2024
54b4f59
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 21, 2024
f93c834
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 22, 2024
9c79538
Merge branch 'main' into 11100-address-eslint-warnings
Daniel-Cross Oct 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ module.exports = {
rules: {
// under discussion
'no-unused-vars': 'off',
'react/no-unstable-nested-components': [
'warn',
{
allowAsProps: true,
Daniel-Cross marked this conversation as resolved.
Show resolved Hide resolved
},
],
},
},
{
Expand Down
4 changes: 3 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@
"cucumberautocomplete.steps": ["wdio/step-definitions/**/*.js"],
"cucumberautocomplete.syncfeatures": "wdio/to/features/*.feature",
"cucumberautocomplete.strictGherkinCompletion": true,
"typescript.tsdk": "node_modules/typescript/lib"
"typescript.tsdk": "node_modules/typescript/lib",
"javascript.preferences.importModuleSpecifier": "relative",
tommasini marked this conversation as resolved.
Show resolved Hide resolved
"typescript.preferences.importModuleSpecifier": "relative"
}
2 changes: 1 addition & 1 deletion app/actions/onboarding/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ export function clearOnboardingEvents(): ClearEventsAction {
return {
type: CLEAR_EVENTS,
};
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const ContractBoxBase = ({
theme: { colors },
} = useStyles(styleSheet, {});

const IconView = ({ onPress, name, size, testID }: IconViewProps) => (
const renderIconView = ({ onPress, name, size, testID }: IconViewProps) => (
<Pressable style={styles.icon} onPress={onPress} testID={testID}>
<Icon color={colors.icon.alternative} name={name} size={size} />
</Pressable>
Expand Down Expand Up @@ -78,20 +78,19 @@ const ContractBoxBase = ({
)}
</View>
<View style={styles.iconContainer}>
<IconView
onPress={onCopyAddress}
name={IconName.Copy}
size={IconSize.Lg}
testID={COPY_ICON_TEST_ID}
/>
{hasBlockExplorer && (
<IconView
name={IconName.Export}
onPress={onExportAddress}
size={IconSize.Md}
testID={EXPORT_ICON_TEST_ID}
/>
)}
{renderIconView({
onPress: onCopyAddress,
name: IconName.Copy,
size: IconSize.Lg,
testID: COPY_ICON_TEST_ID,
})}
{hasBlockExplorer &&
renderIconView({
onPress: onExportAddress,
name: IconName.Export,
size: IconSize.Md,
testID: EXPORT_ICON_TEST_ID,
})}
</View>
</View>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,21 @@ exports[`Component ContractBoxBase should render correctly 1`] = `
}
}
>
<IconView
name="Copy"
<Component
onPress={[Function]}
size="24"
style={
{
"paddingHorizontal": 6,
}
}
testID="copy-icon"
/>
>
<Icon
color="#6a737d"
name="Copy"
size="24"
/>
</Component>
</View>
</View>
`;
Loading
Loading