Fix type safety in Robot Framework JSON validation methods #2
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_should_be_valid()was annotated to returndictbut returned whateverjson.loads()yielded. When the model returned JSON arrays or primitives,json_should_have_keys()raisedAttributeErrorinstead of a clear assertion failure.Changes
isinstance(data, dict)check injson_should_be_valid()after parsing JSONAssertionErrorwith clear message when JSON is not an object:"Expected JSON object (dict), but got list"json_should_have_keys()that upstream validates dict typeExample
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.