Skip to content

Fix type safety in Robot Framework JSON validation methods #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: feat/testing-samples
Choose a base branch
from
Draft

Fix type safety in Robot Framework JSON validation methods #2

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9deb23
Initial plan
Copilot Feb 9, 2026
6753272
fix: add isinstance check in json_should_be_valid to prevent Attribut…
Copilot Feb 9, 2026
fda9df4
style: remove extra blank line for consistent spacing
Copilot Feb 9, 2026
144b2ab
style: use consistent 300-char truncation in error messages
Copilot Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion samples/robot_copilot_library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,19 +195,26 @@ def json_should_be_valid(self) -> dict:
"""Assert that the last response is valid JSON and return the parsed dict."""
try:
data = json.loads(self._last_response)
return data
except json.JSONDecodeError as e:
raise AssertionError(
f"Invalid JSON: {e}\n\nRaw:\n{self._last_response[:300]}"
)

if not isinstance(data, dict):
raise AssertionError(
f"Expected JSON object (dict), but got {type(data).__name__}.\n"
f"Value: {str(data)[:300]}"
)
return data

def json_should_have_keys(self, *keys):
"""Assert that the parsed JSON contains all specified keys.

Example (Robot):
JSON Should Have Keys name age email
"""
data = self.json_should_be_valid()
# json_should_be_valid() already asserts isinstance(data, dict)
missing = set(keys) - set(data.keys())
if missing:
raise AssertionError(
Expand Down