Skip to content

Conversation

@elral
Copy link
Collaborator

@elral elral commented Nov 1, 2024

Description of changes

This is a major PR but it has only editorial changes. Functionality is not changed, tested by compiling this branch and the main branch. For all boards the hex size hasn't changed.

  1. All files are opend and autoformatted. So each file is affected by this PR
  2. Most files have included mobiflight.h which included severall more .h files. For most files, all include files are not required. So mobiflight.h is deleted and in each other file only the required include files are included.
  3. Board definition is done in two different locations, in MF_Boards.h for each board and platformio.ini. With this PR all board definitions are moved to platformio.ini and all MF_Boards.h files are deleted. All board.json files and reset.hex files are now in one folder. Therefore the copy_fw_files.py is also adapted.
  4. Mixed usage of ifdef and if defined() is commonly changed to if defined().

@github-actions
Copy link

github-actions bot commented Nov 1, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change all

#if defined(MF_OUTPUT_SHIFTER_SUPPORT)

to

#ifdef MF_OUTPUT_SHIFTER_SUPPORT

Find: #if\s*defined\s*\(\s*([A-Za-z0-9_]+)\s*\)
Replace #ifdef $1 or #ifdef \1

@github-actions
Copy link

github-actions bot commented Jan 7, 2025

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

@github-actions
Copy link

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

@github-actions
Copy link

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

@DocMoebiuz DocMoebiuz added development enhancement New feature or request labels Jul 30, 2025
@DocMoebiuz DocMoebiuz merged commit ce2dea0 into MobiFlight:main Jul 30, 2025
1 check passed
@elral elral deleted the cleanup_sources branch July 30, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants