Skip to content

feat: Modify GitHub workflow file#17

Closed
VSteveHL wants to merge 4 commits intoMoganLab:mainfrom
VSteveHL:main
Closed

feat: Modify GitHub workflow file#17
VSteveHL wants to merge 4 commits intoMoganLab:mainfrom
VSteveHL:main

Conversation

@VSteveHL
Copy link
Collaborator

@VSteveHL VSteveHL commented Jul 7, 2025

I have modified the .github/workflows/release.yaml file and made the following changes:

  • Removed the repo variable:
    • This variable specifies which repository the release targets. Since its default value is the current repository, I believe leaving it empty is reasonable.
  • Added name
  • Added tag_name
  • Added body to provide some contextual information.

It is worth noting that in the softprops/action-gh-release action, the overwrite_files variable defaults to True. This means that when we explicitly specify a tag_name, the workflow will not repeatedly create new releases but will instead update the files associated with the specified tag. I think this behavior is reasonable for automated builds. However, if you consider this behavior inappropriate, we could modify the tag_name to a format like automated_build-${{ github.run_number }}. This way, a new release would be created for each commit.

For more configurable options in softprops/action-gh-release, you can refer to: https://github.com/softprops/action-gh-release#inputs

I have modified the `.github/workflows/release.yaml` file and made the following changes:

- Removed the `repo` variable:
    - This variable specifies which repository the release targets. Since its default value is the current repository, I believe leaving it empty is reasonable.
- Added `name`
- Added `tag_name`
- Added `body` to provide some contextual information.
@VSteveHL
Copy link
Collaborator Author

VSteveHL commented Jul 7, 2025

Additionally, I noticed that the current Dockerfile is still using Chez 9.6.4. I'm not sure if the Dockerfile needs to be updated.

In commit 0d79527, a modification was made to `.github/workflows/release.yaml`, adding the `--static` parameter in the "Compile executable on Linux musl" step. However, the corresponding `Dockerfile.musl` was not updated, which caused errors during the build process. This commit adds the `util-linux-static` package to `Dockerfile.musl`, allowing the build to proceed successfully.
@VSteveHL
Copy link
Collaborator Author

VSteveHL commented Jul 7, 2025

fix: Fix Dockerfile.musl issue preventing --static compilation

In commit 0d79527, a modification was made to .github/workflows/release.yaml, adding the --static parameter in the "Compile executable on Linux musl" step. However, the corresponding Dockerfile.musl was not updated, which caused errors during the build process. This commit adds the util-linux-static package to Dockerfile.musl, allowing the build to proceed successfully.

@VSteveHL
Copy link
Collaborator Author

VSteveHL commented Jul 7, 2025

I did not modify .github/workflows/test.yaml or Dockerfile. I believe the build-and-test error in this CI run was not caused by my changes.

@VSteveHL
Copy link
Collaborator Author

VSteveHL commented Jul 7, 2025

In the build-and-release process, the release step did not execute correctly due to repository permission settings. To allow the CI process to create release files properly, you need to set the repository's settings under Settings → Actions → General → Workflow permissions to "Read and write permissions." However, this may grant excessive workflow permissions, potentially leading to security issues. I hope you can weigh the pros and cons before deciding how to further improve the workflow in this regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant