Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lawbringer Audio, code improvements, and firing lock. #337

Merged
merged 12 commits into from
Sep 18, 2023

Conversation

KittyNoodle
Copy link
Contributor

@KittyNoodle KittyNoodle commented Sep 10, 2023

About The Pull Request

Improves some lawbringer code.

Makes bigshot less prone to breaching the station.
Detain now does as much damage as i had intended it to.

Adds a firing lock that gets progressively more pissed at you the more you use it.

Adds audio for the lawbringer

Part 2

  • Audio
  • Fix Conflicts
  • Bigshot fixes
  • Code Improvements
  • Basic Locking Functionality
  • Anger System
  • Buff/Fix detain
  • Update Manual

Part 3

  • Internal damage with emps, emags, and anger responses
  • Diagnostic report in description.
  • Self Repair
  • Buff gun a bit to compensate
  • Replacement Protomatter Generator from cargo
  • Update Manual

Why It's Good For The Game

I AM THE LAW

I was originally not planning on including a firing lock, however with the introduction of the audio to the lawbringer, i found it might be disruptive during conversations where words including "ion" or "hot" may be used. I have implemented a small catch) to the lock, that being the gun gets progressively angrier the more you trigger it with the lock on, eventually resulting in it occasionally ignoring the lock, drawing some power, and finally zapping you(or two other possible outcomes)

Changelog

🆑
add: The Lawbringer now has a lock, however, be careful using it, as it tends to make it upset.
fix: Bigshot no longer vents the station while blowing up doors/machines.
balance: Detain now does double the previous damage, as originally intended.
sound: The Lawbringer will now talk/yell at you.
spellcheck: fixed projectile name for clownshot.
code: Lots of code improvements for Lawbringer, redundant code is mostly gone.
/:cl:

@NanoCats
Copy link
Contributor

It still has some issues I personally would like to see addressed

  • You made clownshot not maim the clown to near death, but now it doesn't seem to do anything(?)
  • The disabler function often just doesn't work great for me
  • I still think it could use some sprite work so I can tell it's charging easier, you picked some colors for these modes that are really tough to see
  • Some of the modes are just bad and obnoxious if the hos is new and bad. Take the fire shot for example, had a hos use this on a suspect and lit me on fire like 5 times (as an officer)

Also Idk about the firing lock that sounds like it'll get annoying fast, the clown is a frequent discussion topic on the station, and the gun has so many trigger words, and it triggers from partial words like "Champion" will trigger Ion mode

When I play HOS I mostly find myself using this gun for one of two things:

  1. Keep it in my back pocket for the kill mode bullets
  2. Breach shot

if this thing shocks me I'm deep frying it mark my fucking words

@KittyNoodle
Copy link
Contributor Author

It still has some issues I personally would like to see addressed

  • You made clownshot not maim the clown to near death, but now it doesn't seem to do anything(?)

I made no changes to it, the clown you were shooting did not have the clumsy gene

  • The disabler function often just doesn't work great for me

Ok, I might buff again later, I am happy where it is now. Try using it in tight hallways against single targets, I found that if used properly it only needs 1-2 shots to knock someone down

  • I still think it could use some sprite work so I can tell it's charging easier, you picked some colors for these modes that are really tough to see

we have someone working on new sprites, not gonna make any changes until that’s done.

  • Some of the modes are just bad and obnoxious if the hos is new and bad. Take the fire shot for example, had a hos use this on a suspect and lit me on fire like 5 times (as an officer)

this is a player issue, if the hos is insistent on using fire to kill people they are arresting, they would do it another way

Also Idk about the firing lock that sounds like it'll get annoying fast, the clown is a frequent discussion topic on the station, and the gun has so many trigger words, and it triggers from partial words like "Champion" will trigger Ion mode

my testing with the lock shows that it takes roughly 18 consecutive triggers of the lock to cause a failure, turning it off causes anger to go down pretty fast.

When I play HOS I mostly find myself using this gun for one of two things:

  1. Keep it in my back pocket for the kill mode bullets
  2. Breach shot

if this thing shocks me I'm deep frying it mark my fucking words

@NanoCats
Copy link
Contributor

what if my target isn't in a narrow hallway and all the shots just go into the void

@dwasint dwasint marked this pull request as ready for review September 18, 2023 03:55
@dwasint dwasint merged commit 3228df5 into Monkestation:master Sep 18, 2023
22 checks passed
github-actions bot added a commit that referenced this pull request Sep 18, 2023
@KittyNoodle KittyNoodle deleted the lawbringer branch November 13, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants