Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equation number repetition #566

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

vgeorge
Copy link
Contributor

@vgeorge vgeorge commented Oct 20, 2023

This changes the equation component to use the element path instead of its content to determine uniqueness. Should fix issue reported at NASA-IMPACT/nasa-apt#681 (comment).

To test, add multiple empty and non-empty equations to a document and check if the number is incrementing without repetition.

@wrynearson @frozenhelium ready for review.

Copy link
Member

@wrynearson wrynearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wrynearson wrynearson merged commit fe57369 into develop Oct 20, 2023
14 checks passed
@wrynearson wrynearson deleted the fix/equation-number-repetition branch October 20, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants