Extended packed designation functionality

[hhsieh00]

Added functionality for extended packed provisional designations to be implemented by the MPC in anticipation of higher discovery rates from LSST (https://minorplanetcenter.net/mpcops/documentation/provisional-designation-definition/)

[pep8speaks]

Hello @hhsieh00! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-09-06 21:02:13 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 99.00990% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.19%. Comparing base (df7f292) to head (e8f5699).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
sbpy/data/names.py	98.21%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   82.99%   83.19%   +0.20%     
==========================================
  Files          88       88              
  Lines        8109     8183      +74     
==========================================
+ Hits         6730     6808      +78     
+ Misses       1379     1375       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mkelley]

I'll do a detailed review later, but it looks like two of your lines are not covered by the tests:

https://app.codecov.io/gh/NASA-Planetary-Science/sbpy/pull/406/blob/sbpy/data/names.py#L164

Can you add a case that raises IndexError or ValueError? You can test it like so:

def test_raises_error():
    with pytest.raises(IndexError):
        Names.to_packed("bad_input_here")

There are a couple other blocks not in our testing suite, but they don't seem to be related to your edits, so I won't make you cover them.

[hhsieh00]

Just a note, I think line 140 (which I didn't write, but just put inside a try-except block; but which is currently flagged as uncovered code) is extraneous, since the "s[6:].isdigit()" condition above it should already prevent anything that looks like "1995 A" (i.e., single letter, no subscript) from being passed through that section. As such, I think it can be deleted, but just wanted to get a second opinion before doing so.

[mkelley]

You're right, except that we can get to that line with a cometary fragment style designation. I'm seeing two problems.
Something like "1234 A-A" returns a value, but should raise an error, right? Also, lines 129 and 131 test for the hyphen that denotes a fragment. They test s[-2] but fragments could be two characters (73P-BA). The testing suite doesn't check for two character fragments, but it should.

In [3]: Names.to_packed("2024 A-A")
Out[3]: 'K24A00a'

They are unrelated, so we should proceed with this PR, and open issues for each of them.

[hhsieh00]

Oh yeah, I did notice that multi-letter fragments were not accounted for in the code, but also that they do not seem to be accounted for by the MPC's own documentation (https://www.minorplanetcenter.net/iau/info/PackedDes.html), except by making the 7 character packed designation into an 8 character designation since the fragment is simply recorded in plain-text. And yeah, 1234 A-A seems like a different issue, so maybe better to treat it with a separate issue/PR?

[hhsieh00]

By the way, just for traceability, in working on the code for the extended packed provisional designations, I found that the MPC had also extended its scheme for packed permanent designations beyond 620000, so code for handling extended packed permanent designations is also included in this PR.

[mkelley]

The updates look good. Since you tagged it v0.6, we will merge after v0.5 is out.

[mkelley]

This variable is not used and should be deleted.

[hhsieh00]

done!

[mkelley]

You'll need to rebase with the updated main branch, then resolve the changes.rst conflicts. Let me know if you want some tips.

[hhsieh00]

Hm, yeah, can you send me info on how to do that? Thanks!

[mkelley]

Congrats!