Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended packed designation functionality #406

Commits on Sep 6, 2024

  1. squashed commits for names.py

    removed second instance of pkd_noI definition
    
    fixed test
    
    Update test_names.py
    
    Update test_names.py
    
    changed indentation of a closing )
    
    fixed error with unpacking permanent desigs
    
    fixed typo
    
    modified code structure slightly + added tests
    
    removed test_break_packed() case that is no longer invalid
    
    fixed typo in test to_packed() statements
    
    added quotes to numerical designations in test statements
    
    fixed typos
    
    added functionality for extended permanent asteroid designations
    
    continuing to try to cover code with tests
    
    Update test_names.py
    
    Update test_names.py
    
    added another test error
    
    added different test errors
    
    Update test_names.py
    
    Update test_names.py
    
    error not being raised...testing more
    
    testing error raising
    
    removed example that didn't raise error
    
    changed ValueError and IndexError to TargetNameParseError
    
    changed some ValueError examples to IndexError
    
    added ValueError examples to test_names.py
    
    added ValueError examples to test_names.py
    
    fixed typo
    
    fixed typo
    
    added more data validation
    
    added more data validation checks and fixed some typos
    
    Update names.py
    
    Added check for value errors in to_packed
    
    Added check for value errors in extended provisional designation code block of to_packed()
    
    missing quotes in example results
    
    added missing quotes in example results
    
    fixed another bug in to_packed()
    
    fixed another bug in to_packed() where designations with 2-digit subscripts were getting skipped
    
    fixed error where some packed desigs were failing
    
    return statement was missing in to_packed() for provisional designations with no subscript number or subscripts of 1
    
    various changes
    
    - added examples of extended provisional designation handling to names.rst
    - fixed bug in to_packed()
    - added tests to test_names.py
    
    forgot math import command
    
    forgot math import command
    
    Added/removed white spaces
    
    Added/removed white spaces
    
    Added extended packed desig functionality
    
    Added functionality for extended packed provisional designations to be implemented by the MPC in anticipation of higher discovery rates from LSST (https://minorplanetcenter.net/mpcops/documentation/provisional-designation-definition/)
    hhsieh00 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e8f5699 View commit details
    Browse the repository at this point in the history