Command-line driver for MICM #326
Conversation
boulderdaze
changed the title
Co-authored-by: Kyle Shores <kyle.shores44@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 96.07% 91.09% -4.99%
==========================================
Files 37 38 +1
Lines 2852 3008 +156
==========================================
Hits 2740 2740
- Misses 112 268 +156 ☔ View full report in Codecov by Sentry. |
| CONC.O,0.566253459937848 | ||
| CONC.O2,0.566253459937848 | ||
| CONC.O3,0.566253459937848 | ||
| ENV.temperature,287.45 |
There was a problem hiding this comment.
Do we want to use environmental conditions for the stratosphere, say around z = 30 km?
There was a problem hiding this comment.
that would make slightly more sense for chapman
| // solving until we finish | ||
| double elapsed_solve_time = 0; | ||
|
|
||
| while (elapsed_solve_time < time_step) |
There was a problem hiding this comment.
Perhaps also an option for multiple time steps would be nice at some point.
|
@boulderdaze would you please add support for running carbon bond 5? There are conditions for the rate constants all the way back at this commit |
boulderdaze
changed the title
Yes, |
include/micm/solver/state.inl
Outdated
| // Print only the first 10 if the number of elements are bigger than 10 | ||
| if (variable_names_.size() > 10) | ||
| { | ||
| for(short i=0; i<10; i++) | ||
| { | ||
| std::cout << "," << std::setw(width) << variable_names_[i]; | ||
| } | ||
| std::cout << std::setw(width) << "..." << std::endl; | ||
| } |
There was a problem hiding this comment.
We should print everything. That way the output could be redirected to a file.
include/micm/solver/state.inl
Outdated
| // Print only the first 10 if the number of elements are bigger than 10 | ||
| if (variable_names_.size() > 10) | ||
| { | ||
| for(short i=0; i<10; i++) | ||
| { | ||
| std::cout << std::scientific << "," << std::setw(width) << std::setprecision(2) << variables_[0][variable_map_[variable_names_[i]]]; | ||
| } | ||
| std::cout << std::scientific << std::setw(width) << std::setprecision(2) << "..."; | ||
| } |
There was a problem hiding this comment.
Same here, please print everything
Closes #308
Created try-out example configurations with a single grid cell and a set of initial conditions from a CSV file