Open
Conversation
gbarter
reviewed
Mar 18, 2026
| mem_prom = mem_prom_base + [("cd_usr", f"memload{k}.cd_usr"), ("ca_usr", f"memload{k}.ca_usr")] | ||
| elif shape == "rectangular": | ||
| mem_prom = mem_prom_base + [("cd_usr", f"memload{k}.cd_usr"), ("cdy_usr", f"memload{k}.cdy_usr"), ("ca_usr", f"memload{k}.ca_usr"), ("cay_usr", f"memload{k}.cay_usr")] | ||
|
|
Member
There was a problem hiding this comment.
Seems like the issue was that the old code had "cd_usr" and "ca_usr" etc that were added to the promote list each time in the k-for-loop. Not sure if deleting all together is the right solution. . .
Contributor
Author
There was a problem hiding this comment.
I think it's promoting for each member, and the tuple is (old_name, new_name)
I decided to remove this because I became convinced that the issue was that these outputs were being promoted both here and here.
Member
There was a problem hiding this comment.
I see, okay. Thanks for explaining
Contributor
Author
|
I should have noted in the PR that this is a starting point, and I'm not sure this is the correct way to fix this. It's one way to bypass the error I was getting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I ran into an issue in WEIS using the latest version of openmdao (3.43): https://github.com/dzalkind/WEIS/actions/runs/23260484956/job/67627345448#step:9:233
It seems like in v3.43, openmdao is checking connections and making graphs: https://github.com/OpenMDAO/OpenMDAO/releases. I traced the error to this new feature, which seems to run regardless of whether you use the new command, and it's getting stuck around the
ca_usr_gridand other member load inputs/outputs.These inputs seem to be connected/promoted more than once, and this change seemed to make my example on the WEIS-side work.
Type of change
Testing
Checklist