Skip to content

OpenMDAO 3.43 Support #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzalkind wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −5
Open

OpenMDAO 3.43 Support #702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions wisdem/floatingse/floating_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,10 +698,7 @@ def setup(self):
n_full = get_nfull(opt["floating"]["members"]["n_height"][k], nref=2)
shape = opt["floating"]["members"]["outer_shape"][k]
kname = opt['floating']['members']['name'][k]
if shape == "circular":
mem_prom = mem_prom_base + [("cd_usr", f"memload{k}.cd_usr"), ("ca_usr", f"memload{k}.ca_usr")]
elif shape == "rectangular":
mem_prom = mem_prom_base + [("cd_usr", f"memload{k}.cd_usr"), ("cdy_usr", f"memload{k}.cdy_usr"), ("ca_usr", f"memload{k}.ca_usr"), ("cay_usr", f"memload{k}.cay_usr")]

Copy link
Member

@gbarter gbarter Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the issue was that the old code had "cd_usr" and "ca_usr" etc that were added to the promote list each time in the k-for-loop. Not sure if deleting all together is the right solution. . .

Copy link
Contributor Author

@dzalkind dzalkind Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's promoting for each member, and the tuple is (old_name, new_name)

I decided to remove this because I became convinced that the issue was that these outputs were being promoted both here and here.

Copy link
Member

@gbarter gbarter Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, okay. Thanks for explaining

self.add_subsystem(
f"memload{k}",
MemberLoads(
Expand All @@ -711,7 +708,7 @@ def setup(self):
memmax=True,
member_shape=shape,
),
promotes=mem_prom + U_prom + [("joint1", f"member{k}_{kname}:joint1"), ("joint2", f"member{k}_{kname}:joint2")],
promotes= mem_prom_base + U_prom + [("joint1", f"member{k}_{kname}:joint1"), ("joint2", f"member{k}_{kname}:joint2")],
)

self.add_subsystem("loadsys", PlatformLoads(options=opt), promotes=["*"])
Expand Down
Loading