Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unconventional names #2142

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Fix unconventional names #2142

merged 2 commits into from
Aug 9, 2024

Conversation

scarlehoff
Copy link
Member

@scarlehoff scarlehoff commented Aug 9, 2024 •
edited
Loading

If you want @giacomomagni I can also update the python code where I commented in this PR.

The names changes in this PR are:

STAR_2004_1JET_200GEV    STAR-2004_1JET_200GEV
STAR_2005_1JET_200GEV STAR-2005_1JET_200GEV
STAR_2006_1JET_200GEV STAR-2006_1JET_200GEV
STAR_2009_1JET_200GEV STAR-2009_1JET_200GEV
STAR_2009_2JET_200GEV STAR-2009_2JET_200GEV
STAR_2009_2JET_MIDRAP_200GEV STAR-2009_2JET_200GEV_MIDRAP
STAR_2012_1JET_510GEV STAR-2012_1JET_510GEV
STAR_2012_2JET_510GEV STAR-2012_2JET_510GEV
STAR_2013_1JET_510GEV STAR-2013_1JET_510GEV
STAR_2013_2JET_510GEV STAR-2013_2JET_510GEV
STAR_2015_1JET_200GEV STAR-2015_1JET_200GEV
STAR_2015_2JET_MIDRAP_200GEV STAR-2015_2JET_200GEV_MIDRAP
ATLAS_WJ_JET_8TEV ATLAS_WJ_8TEV

@giacomomagni
Copy link
Contributor

If you want @giacomomagni I can also update the python code where I commented in this PR.

Okay thanks.

For completeness is the naming convention written somewhere in the documentation?

@scarlehoff
Copy link
Member Author

Yes https://docs.nnpdf.science/data/dataset-naming-convention.html

It is probably one of the few things that we have documented well :__

Radonirinaunimi
Radonirinaunimi approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@Radonirinaunimi Radonirinaunimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@scarlehoff scarlehoff merged commit 23a76be into polarized-kin-coverage Aug 9, 2024
6 checks passed
@scarlehoff scarlehoff deleted the fix_dasets_names1 branch August 9, 2024 12:20
@giacomomagni giacomomagni mentioned this pull request Aug 12, 2024
Merged
@Radonirinaunimi Radonirinaunimi mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacomomagni giacomomagni giacomomagni approved these changes

@Radonirinaunimi Radonirinaunimi Radonirinaunimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scarlehoff @giacomomagni @Radonirinaunimi